Fix misdirected links in Web UI from pod conversion #8302
Conversation
|
@jackgr: please review |
| @@ -21,7 +21,7 @@ | |||
| <tr> | |||
| <td class="name">Status</td> | |||
| <td class="value"> | |||
| {{pod.currentState.status}} on <a ng-href="/#/dashboard/groups/host/selector/host={{pod.currentState.host}}">{{pod.currentState.host}}</a> | |||
| {{pod.currentState.status}} on <a ng-href="#/dashboard/groups/host/selector/host={{pod.currentState.host}}">{{pod.currentState.host}}</a> | |||
There was a problem hiding this comment.
Please convert to v1beta3 syntax. We're eliminating v1beta1 within the next week or two.
https://github.com/GoogleCloudPlatform/kubernetes/blob/master/docs/api.md#v1beta3-conversion-tips
https://github.com/GoogleCloudPlatform/kubernetes/blob/master/pkg/api/v1beta3/types.go
bcbroussard
changed the title
|
@bgrant0607 Thanks. I've created a new PR - #8304 for the v1beta3 updates to make rollbacks easier. |
bcbroussard
changed the title
bcbroussard
changed the title
|
LGTM, rerunning shippable. I think it's reasonable to fix @bgrant0607's comments in another PR. But please do it soon, because v1beta1 is going away. |
|
Does this overlap at all with #8332? |
|
@bgrant0607 There is no overlap with #8322. You can go ahead and merge this, and @preillyme will rebase to incorporate these changes into the UI binary. |
|
@lavalamp I'll be working on v1beta3 support after these UI fixes. Should be finished by early next week at the latest. |
|
One shippable run passed. The other looked like an infrastructure failure, not a test failure. It doesn't look like travis will run any time soon. I'm not sure we have any test coverage of this, anyway. LGTM. |
Fix misdirected links in Web UI from pod conversion
|
👍 |
1 similar comment
|
👍 |
From the comments in #7122 .
Fixes the blue Kubernetes logo link and a number of others.
cc /@lavalamp @bgrant0607