-
Notifications
You must be signed in to change notification settings - Fork 38.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore missing WebUI breadcrumbs after refactor #8332
Conversation
@lavalamp can you please review this change: |
Once these changes #8302 are merged the links will function correctly again. The move from running in a pod to running directly from the API Server seems to have definitely caused some issues. |
cc @jackgr |
- Update paths to svg images - Restore sections concept - Tested with local cluster
- Update back buttons - Ignore duplicated README.md - Rename /minions to /nodes - Deactivate more buttons - Updates to list selection and node detail page
Can you add a test to ensure that this doesn't get broken in the future? Also, the bindata go file seems to have gotten its boilerplate header messed up, which is why travis & shippable are mad at you. Please fix it it (for extra credit, fix the thing that generated it?) |
Breadcrumbs and back button still don't work correctly:
|
@lavalamp it looks like currently that |
@preillyme have not checked older versions. |
@jackgr Okay I'll check the older version shortly. I'm curious if it was always broken or just broke now. I suspect it's something with: |
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
@jackgr PTAL, I've added another commit to address the issues in your comment, along with a few other minor updates.
|
@googlebot I’m okay with these commits https://github.com/preillyme/kubernetes/commit/4ce6783a8ac3ad1a9a4e15a7619f7c8588cf8e18 being contributed to Google |
This now looks good to me. @lavalamp can you take a look please. |
👍 |
@lavalamp Can you please review this PR? |
@jackgr reviewed, so I'm going to put lgtm on this. |
Please rebase so that I can merge your pr, sorry for the inconvienence. |
Needs rebase. |
Also this seems light on tests? Should I not worry about that? |
CLAs look good, thanks! |
@lavalamp I've rebased. Yes this is also pretty light on tests but we've got some other changes around testing coming soon in another PR. So I wouldn't worry about it in this PR. |
Restore missing WebUI breadcrumbs after refactor
hack/local-up-cluster.sh