Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use go1.12.10 #83139

Merged
merged 1 commit into from
Sep 26, 2019
Merged

Conversation

cblecker
Copy link
Member

What type of PR is this?
/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:
ref #83138

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Update to go 1.12.10

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 26, 2019
@cblecker
Copy link
Member Author

/area release-eng
/sig release
/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 26, 2019
@cblecker
Copy link
Member Author

@javier-b-perez @BenTheElder would one of you mind having a look at building this image?

@BenTheElder
Copy link
Member

LGTM

@BenTheElder
Copy link
Member

pushed staging-k8s.gcr.io/kube-cross:v1.12.10-1@sha256:c5a1a501310883f47642cc711fe5228d585d7e881acb661387bcb00e2e674a2a, will need to file an image promotion CL

@BenTheElder
Copy link
Member

cl/271260136 promotes this image, pending approve + lgtm

@BenTheElder
Copy link
Member

/lgtm
/approve
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 26, 2019
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 26, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, cblecker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BenTheElder
Copy link
Member

/uncc @ixdy
Jeff you should probably update OWNERS :^)

@k8s-ci-robot k8s-ci-robot removed the request for review from ixdy September 26, 2019 02:44
@BenTheElder
Copy link
Member

[also note the hold is until the image exists, so we don't get retest spam]

@liggitt liggitt mentioned this pull request Sep 26, 2019
9 tasks
@BenTheElder
Copy link
Member

cl/271260136 has been submitted but the image is not available yet

@cblecker
Copy link
Member Author

/test all

@BenTheElder
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 26, 2019
k8s-ci-robot added a commit that referenced this pull request Sep 26, 2019
@k8s-ci-robot k8s-ci-robot merged commit 66755bd into kubernetes:master Sep 26, 2019
@k8s-ci-robot k8s-ci-robot merged commit 15bba1f into kubernetes:master Sep 26, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Sep 26, 2019
@BenTheElder
Copy link
Member

BenTheElder commented Sep 26, 2019 via email

@cblecker cblecker deleted the here-we-go-again branch September 26, 2019 23:27
k8s-ci-robot added a commit that referenced this pull request Sep 27, 2019
…39-upstream-release-1.14

Automated cherry pick of #83139: Update to use go1.12.10
k8s-ci-robot added a commit that referenced this pull request Sep 27, 2019
…39-upstream-release-1.15

Automated cherry pick of #83139: Update to use go1.12.10
k8s-ci-robot added a commit that referenced this pull request Sep 27, 2019
…39-upstream-release-1.16

Automated cherry pick of #83139: Update to use go1.12.10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants