Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency vmware/govmomi to v0.20.3 #83505

Merged
merged 1 commit into from Nov 15, 2019

Conversation

misterikkit
Copy link

@misterikkit misterikkit commented Oct 4, 2019

What type of PR is this?
/kind bug
/sig storage

What this PR does / why we need it:

Update dependency vmware/govmomi to v0.20.3

govmomi is the vSphere client library used by the vSphere cloud provider
and storage plugin. A bug in the SOAP client prevented storage classes
that use vSphere storage policies (aka SPBM) from working.

This bumps our dependency on vmware/govmomi from v0.20.1 to v0.20.3 to
pick up the fix in vmware/govmomi#1498

Here are all changes in the release:
vmware/govmomi@v0.20.1...v0.20.3

Which issue(s) this PR fixes:

Fixes #79809

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/storage Categorizes an issue or PR as relevant to SIG Storage. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 4, 2019
@yastij
Copy link
Member

yastij commented Oct 4, 2019

/cc @dougm

@k8s-ci-robot k8s-ci-robot added area/cloudprovider area/dependency Issues or PRs related to dependency changes sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. labels Oct 4, 2019
@k8s-ci-robot k8s-ci-robot requested review from cheftako, liggitt and a team October 4, 2019 16:46
Copy link
Member

@dougm dougm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@misterikkit I could also cherry-pick that fix to the govmomi release-0.20 branch and create a new tag.
I had created the branch to avoid kubernetes vendor churn such as this. Any preference?

@misterikkit
Copy link
Author

misterikkit commented Oct 8, 2019

I could also cherry-pick that fix to the govmomi release-0.20 branch and create a new tag.

@dougm If that's not too much trouble, I think it would be easier to consume here. The cloud provider code is more or less in maintenance mode while it gets replaced with https://github.com/kubernetes/cloud-provider-vsphere .

@dougm
Copy link
Member

dougm commented Oct 8, 2019

@misterikkit no problem at all, done: vmware/govmomi@v0.20.2...v0.20.3

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Nov 7, 2019
@misterikkit misterikkit changed the title Update dependency vmware/govmomi to v0.21.0 Update dependency vmware/govmomi to v0.20.3 Nov 7, 2019
@misterikkit
Copy link
Author

Thanks very much @dougm! This PR now updates to v0.20.3.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 7, 2019

@misterikkit: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-cross 6d8790ea5fa1fcd9c46771d11cd34b18d351b260 link /test pull-kubernetes-cross

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liggitt
Copy link
Member

liggitt commented Nov 7, 2019

lgtm, needs a rebase after #82809 merged

@liggitt liggitt added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 7, 2019
Copy link
Member

@dougm dougm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 7, 2019

misterikkit committed on Oct 4
govmomi is the vSphere client library used by the vSphere cloud provider
and storage plugin. A bug in the SOAP client prevented storage classes
that use vSphere storage policies (aka SPBM) from working.

This bumps our dependency on vmware/govmomi from v0.20.1 to v0.20.3 to
pick up the fix in vmware/govmomi#1498

Here are all changes in the release:
vmware/govmomi@v0.20.1...v0.20.3
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2019
@k8s-ci-robot k8s-ci-robot removed do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 13, 2019
@misterikkit
Copy link
Author

Thanks for the prompt reviews. This has been rebased.

@liggitt
Copy link
Member

liggitt commented Nov 13, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 13, 2019
@liggitt liggitt added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 13, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Nov 13, 2019
@misterikkit
Copy link
Author

@liggitt Does this belong in the v1.18 milestone, then?

@liggitt
Copy link
Member

liggitt commented Nov 15, 2019

sorry, was a race condition between a manual and bot-added label
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, misterikkit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2019
@k8s-ci-robot k8s-ci-robot merged commit 31200d0 into kubernetes:master Nov 15, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to create PVC using a storage class with vSphere storage policy defined (secure connection to vCenter)
5 participants