New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependency vmware/govmomi to v0.20.3 #83505
Conversation
/cc @dougm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@misterikkit I could also cherry-pick that fix to the govmomi release-0.20 branch and create a new tag.
I had created the branch to avoid kubernetes vendor churn such as this. Any preference?
@dougm If that's not too much trouble, I think it would be easier to consume here. The cloud provider code is more or less in maintenance mode while it gets replaced with https://github.com/kubernetes/cloud-provider-vsphere . |
@misterikkit no problem at all, done: vmware/govmomi@v0.20.2...v0.20.3 |
6d8790e
to
b0a8be0
Compare
Thanks very much @dougm! This PR now updates to v0.20.3. |
@misterikkit: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
lgtm, needs a rebase after #82809 merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
 misterikkit committed on Oct 4 govmomi is the vSphere client library used by the vSphere cloud provider and storage plugin. A bug in the SOAP client prevented storage classes that use vSphere storage policies (aka SPBM) from working. This bumps our dependency on vmware/govmomi from v0.20.1 to v0.20.3 to pick up the fix in vmware/govmomi#1498 Here are all changes in the release: vmware/govmomi@v0.20.1...v0.20.3
d4885e9
to
42290dd
Compare
Thanks for the prompt reviews. This has been rebased. |
/lgtm |
@liggitt Does this belong in the v1.18 milestone, then? |
sorry, was a race condition between a manual and bot-added label |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, misterikkit The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
/sig storage
What this PR does / why we need it:
Update dependency vmware/govmomi to v0.20.3
govmomi is the vSphere client library used by the vSphere cloud provider
and storage plugin. A bug in the SOAP client prevented storage classes
that use vSphere storage policies (aka SPBM) from working.
This bumps our dependency on vmware/govmomi from v0.20.1 to v0.20.3 to
pick up the fix in vmware/govmomi#1498
Here are all changes in the release:
vmware/govmomi@v0.20.1...v0.20.3
Which issue(s) this PR fixes:
Fixes #79809
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: