Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Kubelet cmd option to make system reserved CPU list specific #83582

Closed
wants to merge 92 commits into from
Closed

Adding Kubelet cmd option to make system reserved CPU list specific #83582

wants to merge 92 commits into from

Conversation

jianzzha
Copy link
Contributor

@jianzzha jianzzha commented Oct 7, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test

/kind feature

/kind flake

What this PR does / why we need it:

Currently when --system-reserved or --kube-reserved is used, kubelet will reserve system resources and keep them from being used by user containers. What CPUs are reserved via these options are not easy to determine by the end users, even though the CPU selection algorithm make the selection in deterministic way.

For telco NFV use cases, when using static cpu manager policy, knowing explicitly what CPUs are reserved for system and what CPUs are used for user containers is very important. For example, if isolcpu are going to be defined on the kernel cmd line and used for NFV containers, they really should be used only by the NFV containers and not by the system threads. Therefore, providing an option to explicitly define the system reserved CPU list will make the planning job much easier and straightforward for such telco use cases.

This new cmd line option, --reserved-cpus, is to explicitly define the the cpu list that will be reserved for system. For example, if --reserved-cpus=0,1,2,3 is specified, then cpu 0,1,2,3 will be reserved for the system. On a system with 24 CPUs, the telco user may specify isolcpus=4-23 for the kernel option and use CPU 4-24 for the NFV containers.

When --reserved-cpus is specified together --system-reserved or --kube-reserved, the explicit CPU list specified by --reserved-cpus will supercede the CPUs requested via --system-reserved or --kube-reserved.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
cpu manager test cases failures are all inherited from release-1.16. I will submit a another PR to add new test cases around cpu manager.

Does this PR introduce a user-facing change?:

A new kubelet command line option, --reserved-cpus, is introduced to explicitly define the the CPU list that will be reserved for system. For example, if --reserved-cpus=0,1,2,3 is specified, then cpu 0,1,2,3 will be reserved for the system.  On a system with 24 CPUs, the user may specify isolcpus=4-23 for the kernel option and use CPU 4-24 for the user containers.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


Anago GCB and others added 30 commits August 13, 2019 09:01
…ing CHANGELOG-1.13.md CHANGELOG-1.14.md CHANGELOG-1.15.md
k8s-ci-robot and others added 8 commits September 28, 2019 21:19
…stream-release-1.16

Automated cherry pick of #82434: Encryption config: correctly handle overlapping providers
…0-upstream-release-1.16

Automated cherry pick of #83250: Deflake TestWatchBasedManager
…pstream-release-1.16-take-2

Automated cherry pick of #82514: Exec probes should not be unbounded
…1-upstream-release-1.16

[1.16] Automated cherry pick of #83261: bump gopkg.in/yaml.v2 v2.2.4
@k8s-ci-robot
Copy link
Contributor

Welcome @jianzzha!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Oct 7, 2019
@k8s-ci-robot
Copy link
Contributor

@jianzzha: This cherry pick PR is for a release branch and has not yet been approved by the Patch Release Team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, please ping the kubernetes/patch-release-team in a comment, after it has been approved by the relevant OWNERS.
For details on the patch release process and schedule, see the Patch Releases page.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 7, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @jianzzha. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 7, 2019
@k8s-ci-robot
Copy link
Contributor

@jianzzha: Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 7, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jianzzha
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Oct 7, 2019
@k8s-ci-robot
Copy link
Contributor

The following users are mentioned in OWNERS file(s) but are not members of the kubernetes org.

Once all users have been added as members of the org, you can trigger verification by writing /verify-owners in a comment.

  • dghubble
    • OWNERS_ALIASES
  • droot
    • OWNERS_ALIASES
  • zehicle
    • OWNERS_ALIASES
  • fasaxc
    • cluster/addons/calico-policy-controller/OWNERS

@jianzzha jianzzha changed the base branch from release-0.16 to master October 7, 2019 20:05
@jianzzha
Copy link
Contributor Author

jianzzha commented Oct 7, 2019

/check-CLA

@jianzzha
Copy link
Contributor Author

jianzzha commented Oct 7, 2019

/check-cla

@jianzzha jianzzha closed this Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet