-
Notifications
You must be signed in to change notification settings - Fork 39.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use log functions of core framework on testsuites/topology.go #83667
Use log functions of core framework on testsuites/topology.go #83667
Conversation
Thanks for doing this. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: k-toyoda-pi, oomichi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
oops, need to be rebased. /lgtm cancel |
/test pull-kubernetes-e2e-kind |
2 similar comments
/test pull-kubernetes-e2e-kind |
/test pull-kubernetes-e2e-kind |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
…age_topology Use log functions of core framework on testsuites/topology.go
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR makes test/e2e/storage/testsuites/topology.go to use log functions of core framework.
Which issue(s) this PR fixes:
Ref #81427
Special notes for your reviewer:
Does this PR introduce a user-facing change?: