Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use log functions of core framework on testsuites/topology.go #83667

Merged

Conversation

@k-toyoda-pi
Copy link
Contributor

commented Oct 9, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This PR makes test/e2e/storage/testsuites/topology.go to use log functions of core framework.

Which issue(s) this PR fixes:
Ref #81427

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE
@oomichi

This comment has been minimized.

Copy link
Member

commented Oct 9, 2019

Thanks for doing this.

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Oct 9, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k-toyoda-pi, oomichi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@copejon
copejon approved these changes Oct 9, 2019
Copy link
Contributor

left a comment

lgtm

@oomichi

This comment has been minimized.

Copy link
Member

commented Oct 9, 2019

oops, need to be rebased.
@k-toyoda-pi Could you rebase this for the latest master?

/lgtm cancel

@k8s-ci-robot k8s-ci-robot removed the lgtm label Oct 9, 2019
@k-toyoda-pi k-toyoda-pi force-pushed the k-toyoda-pi:use_log_e2e_storage_topology branch from b41ba03 to 1ae7726 Oct 10, 2019
@k-toyoda-pi

This comment has been minimized.

Copy link
Contributor Author

commented Oct 10, 2019

/test pull-kubernetes-e2e-kind

2 similar comments
@oomichi

This comment has been minimized.

Copy link
Member

commented Oct 10, 2019

/test pull-kubernetes-e2e-kind

@odinuge

This comment has been minimized.

Copy link
Member

commented Oct 10, 2019

/test pull-kubernetes-e2e-kind

Copy link
Member

left a comment

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Oct 10, 2019
@k8s-ci-robot k8s-ci-robot merged commit 4eb1ca4 into kubernetes:master Oct 10, 2019
18 checks passed
18 checks passed
cla/linuxfoundation k-toyoda-pi authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-kind-ipv6 Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 10, 2019
@k-toyoda-pi k-toyoda-pi deleted the k-toyoda-pi:use_log_e2e_storage_topology branch Oct 10, 2019
ohsewon added a commit to ohsewon/kubernetes that referenced this pull request Oct 16, 2019
…age_topology

Use log functions of core framework on testsuites/topology.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.