feat: remove suspendedDaemonPods from daemon controller #84323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
draveness
commented
Oct 25, 2019
|
|
||
| switch { | ||
| case wantToRun && !shouldSchedule: | ||
| // If daemon pod is supposed to run, but can not be scheduled, add to suspended list. | ||
| dsc.addSuspendedDaemonPods(node.Name, dsKey) |
There was a problem hiding this comment.
[1] wantToRun and shouldScheudle returns the same all the time
draveness
force-pushed
the
feature/remove-suspended-daemon-pods
branch
from
5b03dab
to
dc437a7
Compare
k8s-ci-robot
added
priority/important-soon
6 tasks
|
/retest |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: draveness, k82cn, kow3ns The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind cleanup
/sig scheduling
/sig apps
What this PR does / why we need it:
After #82795 got merged,
nodeShouldRunDaemonPodalways returns the same value inwantToRunandshouldSchedule. The original path [1] will not execute anymore, we could remove suspenedDaemonPods from the daemon controller.Which issue(s) this PR fixes:
Part of #82702
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: