Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove system validators package from kubeadm and use k8s.io/system-validators #84718

Merged
merged 1 commit into from Nov 12, 2019
Merged

remove system validators package from kubeadm and use k8s.io/system-validators #84718

merged 1 commit into from Nov 12, 2019

Conversation

yastij
Copy link
Member

@yastij yastij commented Nov 4, 2019 •
edited

Signed-off-by: Yassine TIJANI ytijani@vmware.com

What type of PR is this?

/kind cleanup
/priority important-soon

What this PR does / why we need it: This PR removes the system validators package from kubeadm and uses instead k8s.io/system-validators

Which issue(s) this PR fixes: part of kubernetes/kubeadm#1638

Special notes for your reviewer:

/assign @neolit123 @Random-Liu

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 4, 2019
@yastij yastij changed the title remove system validators package from kubeadm and use k8s.io/system-v… remove system validators package from kubeadm and use k8s.io/system-validators Nov 4, 2019
@k8s-ci-robot k8s-ci-robot added area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kubeadm area/kubectl area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 4, 2019
mattjmcnaughton
mattjmcnaughton reviewed Nov 4, 2019
View reviewed changes
Copy link
Contributor

@mattjmcnaughton mattjmcnaughton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming there aren't any behavioral changes here?

Do you mind taking a look at the verify build failures? thanks :)

yastij
yastij commented Nov 4, 2019
View reviewed changes
Copy link
Member Author

@yastij yastij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some notes for @neolit123 and @Random-Liu

go.mod Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
build/dependencies.yaml Show resolved Hide resolved
@neolit123
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 11, 2019
@yastij
remove system validators package from kubeadm and use k8s.io/system-v…
b9fe59c 
…alidators instead

Signed-off-by: Yassine TIJANI <ytijani@vmware.com>
@k8s-ci-robot k8s-ci-robot added area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Nov 12, 2019
@neolit123
Copy link
Member

/remove-area apiserver
/remove-sig api-machinery cli
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. labels Nov 12, 2019
@yastij
Copy link
Member Author

yastij commented Nov 12, 2019

/retest

@yastij
Copy link
Member Author

yastij commented Nov 12, 2019

/assign @liggitt

@liggitt
Copy link
Member

liggitt commented Nov 12, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, liggitt, neolit123, yastij

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2019
@yastij
Copy link
Member Author

yastij commented Nov 12, 2019

@neolit123 @liggitt - feel free to unhold, this should be good to go

@neolit123 neolit123 mentioned this pull request Nov 12, 2019
Closed
@neolit123
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 12, 2019
@neolit123
Copy link
Member

/retest

2 similar comments
@neolit123
Copy link
Member

/retest

@yastij
Copy link
Member Author

yastij commented Nov 12, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit ea2750e into kubernetes:master Nov 12, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Nov 12, 2019
@ehashman ehashman mentioned this pull request Jun 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@BenTheElder BenTheElder BenTheElder left review comments

@liggitt liggitt liggitt left review comments

@rosti rosti rosti left review comments

@mattjmcnaughton mattjmcnaughton mattjmcnaughton left review comments

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

Assignees

@timothysc timothysc

@neolit123 neolit123

@liggitt liggitt

@Random-Liu Random-Liu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/kubeadm area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@yastij @timothysc @caesarxuchao @BenTheElder @neolit123 @liggitt @k8s-ci-robot @rosti @mattjmcnaughton @Random-Liu