Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move password retrieval to openstack_test.go #84992

Merged
merged 1 commit into from Nov 10, 2019

Conversation

@tedyu
Copy link
Contributor

tedyu commented Nov 8, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
Fixes #81117 by moving password retrieval to test.

Which issue(s) this PR fixes:
Fixes #81117

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@yutedz yutedz force-pushed the yutedz:openstack-passwd branch from 7891318 to e304975 Nov 8, 2019
@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Nov 8, 2019

note that this exists to be compatible with https://docs.openstack.org/newton/user-guide/common/cli-set-environment-variables-using-openstack-rc.html

just because we're not using it in-tree doesn't mean it is not in use.

I'll defer to @dims / @kubernetes/provider-openstack-misc on assessing the risk of dropping this

@dims

This comment has been minimized.

Copy link
Member

dims commented Nov 8, 2019

/assign @chrigl @adisky
/lgtm

yes, let's do this please!. it's ok to drop that support.

@dims

This comment has been minimized.

Copy link
Member

dims commented Nov 8, 2019

/priority important-soon
/milestone v1.17

@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Nov 8, 2019
@dims dims removed their assignment Nov 8, 2019
@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Nov 9, 2019

@dims - this needs approval if it will merge in 1.17. Looks like you have approve on the package.

@dims

This comment has been minimized.

Copy link
Member

dims commented Nov 9, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 9, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, tedyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0afc842 into kubernetes:master Nov 10, 2019
15 checks passed
15 checks passed
cla/linuxfoundation yutedz authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.