Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move password retrieval to openstack_test.go #84992

Merged
merged 1 commit into from
Nov 10, 2019

Conversation

tedyu
Copy link
Contributor

@tedyu tedyu commented Nov 8, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
Fixes #81117 by moving password retrieval to test.

Which issue(s) this PR fixes:
Fixes #81117

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 8, 2019
@k8s-ci-robot k8s-ci-robot added area/cloudprovider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 8, 2019
@liggitt
Copy link
Member

liggitt commented Nov 8, 2019

note that this exists to be compatible with https://docs.openstack.org/newton/user-guide/common/cli-set-environment-variables-using-openstack-rc.html

just because we're not using it in-tree doesn't mean it is not in use.

I'll defer to @dims / @kubernetes/provider-openstack-misc on assessing the risk of dropping this

@dims
Copy link
Member

dims commented Nov 8, 2019

/assign @chrigl @adisky
/lgtm

yes, let's do this please!. it's ok to drop that support.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 8, 2019
@dims
Copy link
Member

dims commented Nov 8, 2019

/priority important-soon
/milestone v1.17

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Nov 8, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Nov 8, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Nov 8, 2019
@dims dims removed their assignment Nov 8, 2019
@liggitt
Copy link
Member

liggitt commented Nov 9, 2019

@dims - this needs approval if it will merge in 1.17. Looks like you have approve on the package.

@dims
Copy link
Member

dims commented Nov 9, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, tedyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2019
@k8s-ci-robot k8s-ci-robot merged commit 0afc842 into kubernetes:master Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TOB-K8S-005: Environment variables expose sensitive data
7 participants