-
Notifications
You must be signed in to change notification settings - Fork 39.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move password retrieval to openstack_test.go #84992
Conversation
d1f7134
to
7891318
Compare
7891318
to
e304975
Compare
note that this exists to be compatible with https://docs.openstack.org/newton/user-guide/common/cli-set-environment-variables-using-openstack-rc.html just because we're not using it in-tree doesn't mean it is not in use. I'll defer to @dims / @kubernetes/provider-openstack-misc on assessing the risk of dropping this |
/priority important-soon |
@dims - this needs approval if it will merge in 1.17. Looks like you have approve on the package. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, tedyu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fixes #81117 by moving password retrieval to test.
Which issue(s) this PR fixes:
Fixes #81117
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: