fix vmss dirty cache issue #85158
Merged
fix vmss dirty cache issue #85158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
release-note
k8s-ci-robot
added
size/S
k8s-ci-robot
added
area/cloudprovider
approved
|
Note that this was changed already between 1.15 and 1.16. |
|
Oh nevermind I see it was changed in 1.15.5 |
staging/src/k8s.io/legacy-cloud-providers/azure/azure_controller_vmss.go
Show resolved
Hide resolved
add logging
andyzhangx
force-pushed
the
vmss-dirty-cache
branch
from
9cef486
to
01ea169
Compare
andyliuliming
approved these changes
Nov 13, 2019
k8s-ci-robot
added
the
lgtm
This was referenced Nov 13, 2019
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, feiskyer, khenidak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added a commit
that referenced
this pull request
Nov 29, 2019
…5158-upstream-release-1.16 Automated cherry pick of #85158: fix vmss dirty cache issue
k8s-ci-robot
added a commit
that referenced
this pull request
Dec 2, 2019
…5158-upstream-release-1.15 Automated cherry pick of #85158: fix vmss dirty cache issue
k8s-ci-robot
added a commit
that referenced
this pull request
Dec 2, 2019
…5158-upstream-release-1.14 Automated cherry pick of #85158: fix vmss dirty cache issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
fix vmss dirty cache issue
clean vmss cache should happen after disk attach/detach operation, now it's before those operations, which would lead to dirty cache.
since update operation may cost 30s or more, and at that time period, if there is another get vmss operation, it would get the old data disk list
Which issue(s) this PR fixes:
Fixes #85159
Special notes for your reviewer:
This dirty cache issue would cause lots of weird disk issues and this issue lies in k8s v1.13.12, v1.13.13, v1.14.8, v1.14.9, v1.15.5, v1.15.6, v1.16.2, v1.16.3 in vmss clusters using data disks
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/kind bug
/assign @feiskyer
/priority important-soon
/sig cloud-provider
/area provider/azure