Ensuring EndpointSlice controller does not start when feature gate or API are disabled #85301
Conversation
Since we've added support for RunAsUserName, we can now run some new tests. However, the [LinuxOnly] tag will have to remain until the WindowsRunAsUserName feature becomes enabled by default. Additionally, Containerd supports file mounting on Windows, and some tests will be able to pass on Windows with Containerd instead of Docker.
The e2e core framework and subpackages of e2e framework are defined. The subpackages can import the core framework, but the core framework should not import the subpackages. We've defined this dependency rule after circular depencency issue happened. This adds TODOs to understand what we should in this rule.
Ensures that requests that require large packets work properly, and that they are not dropped. Adds AgnhostPrivate to test/utils/image/manifest. Some tests are trying to pull the agnhost image from the private registry, meaning that we would need to always build and push the agnhost image to both e2e and private registry whenever we bump its version. Decoupling them would mean that we only need to push the image to the e2e registry.
This includes IPv4 and IPv6 address types and IPVS dual stack support. Importantly this ensures that EndpointSlices with a FQDN address type are not processed by kube-proxy.
Generalized ResourcePolicyRule in API Priority and Fairness to be able to discriminate on the target namespace (if any) specified in the request.
This change is needed to make descriptor lock per pod, in the next commit. If losetup is called for symlink, path in the output for losetup is resolved, as a result, we can't distinguish which path the lock is taken.
This change is needed to avoid unmapVolumeFunc for one pod blocked, when the lock for the same volume is taken for another pod.
k8s-ci-robot
added
area/apiserver
area/cloudprovider
area/code-generation
area/conformance
|
@robscott: Adding label Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
sig/instrumentation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: liggitt, robscott The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
removed
the
approved
|
In case anyone's curious what happened here, the GitHub UI showed this branch as having conflicts with master. I fetched the latest and rebased, but apparently in the minute it took me to do this, the PR actually got merged, so I ended up pushing an update to this branch that had the merge commit of the commit that this PR was originally based on. |
|
@robscott: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This ensures that the EndpointSlice controller will not start when the feature gate or API have been disabled.
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/sig network
/priority important-soon
/milestone v1.17
/cc @liggitt