Make APIService.spec.service optional in the openapi v2 spec #85728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
yue9944882
reviewed
Nov 28, 2019
staging/src/k8s.io/kube-aggregator/pkg/apis/apiregistration/v1beta1/types.go
Outdated
Show resolved
Hide resolved
yue9944882
reviewed
Nov 28, 2019
staging/src/k8s.io/kube-aggregator/pkg/apis/apiregistration/v1/types.go
Outdated
Show resolved
Hide resolved
yue9944882
reviewed
Nov 28, 2019
prksu
force-pushed
the
make-apiservice.spec.service-optional
branch
from
90aaf8d
to
e911833
Compare
|
@yue9944882 i just updated according to your review. please take another look. thanks |
|
/lgtm for another review and approval |
k8s-ci-robot
added
the
lgtm
|
/approve Thanks! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lavalamp, prksu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/sig api-machinery |
k8s-ci-robot
added
sig/api-machinery
diegodelemos
pushed a commit
to diegodelemos/reana-commons
that referenced
this pull request
Jul 3, 2020
* Gets raw data from Kubernetes and avoids OpenAPI deserialization which fails due to kubernetes-client/gen#52, even though [this fix](kubernetes/kubernetes#85728) exists, the Python Kubernetes library is still not compatible with it. More information at kubernetes-client/python#1174.
diegodelemos
pushed a commit
to diegodelemos/reana-commons
that referenced
this pull request
Jul 3, 2020
* Gets raw data from Kubernetes and avoids OpenAPI deserialization which fails due to kubernetes-client/gen#52, even though [this fix](kubernetes/kubernetes#85728) exists, the Python Kubernetes library is still not compatible with it. More information at kubernetes-client/python#1174.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
make APIService.spec.service optional in openapi v2 spec.
this PR fixes failing updates on a "Local" apiservice (unless disabling the client-side validation)
Which issue(s) this PR fixes:
Fixes #84184
Special notes for your reviewer:
/cc @yue9944882
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: