tasks: skip client side node_list validation #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Gets raw data from Kubernetes and avoids OpenAPI deserialization which fails due to kubernetes-client/gen#52, even though [this fix](kubernetes/kubernetes#85728) exists, the Python Kubernetes library is still not compatible with it. More information at kubernetes-client/python#1174.
diegodelemos
force-pushed
the
compatibility-with-k8s-1.18
branch
from
332be1e
to
fbb84c3
Compare
tiborsimko
approved these changes
Jul 3, 2020
There was a problem hiding this comment.
Confirmed working with the Kind branch.
Test script:
(cd ../reana && git reset --hard)
(cd ../reana-workflow-controller && git reset --hard)
reana-dev git-clean -c ALL
reana-dev git-status -c ALL -s
reana-dev cluster-delete
sudo rm -rf /var/reana/*
reana-dev run-ci -m /var/reana:/var/reana --exclude-components=r-ui,r-a-vomsproxy -c r-d-helloworld
reana-dev cluster-undeploy
echo "# test1" >> ../reana-workflow-controller/setup.py
reana-dev docker-build -c r-w-controller
reana-dev kind-load-docker-image -c r-w-controller
reana-dev cluster-deploy
eval "$(reana-dev client-setup-environment)" && reana-dev run-example -c r-d-helloworld
reana-dev cluster-undeploy
echo "# test2" >> ../reana-workflow-controller/setup.py
reana-dev docker-build -c r-w-controller
reana-dev kind-load-docker-image -c r-w-controller
reana-dev cluster-deploy
eval "$(reana-dev client-setup-environment)" && reana-dev run-example -c r-d-helloworld
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fails due to Required arrays with null value kubernetes-client/gen#52,
even though this fix
exists, the Python Kubernetes library is still not compatible with it.
More information at list_api_service: ValueError: Invalid value for
service, must not beNonekubernetes-client/python#1174.