Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[WIP] Updated - topologymanager: Add Merge method to Policy #85798
What type of PR is this?
What this PR does / why we need it:
This patch adds Merge abstraction to Topology Manager policies which
Related Issue: #83478
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
[APPROVALNOTIFIER] This PR is NOT APPROVED
The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
@nolancon: GitHub didn't allow me to request PR reviews from the following users: adrianchiris.
Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.
Can you please break this PR into small incremental commits , each with a single, logical change in them? The main problem with the original PR was that it was too hard to review because lots of changes were smashed into a single commit.
To help with this, I took the original PR and broke (most of it) it into these logical changes:
Derek was then able to merge them the same day I put the PR up because it was much easier to review: #84721 (comment)
It would be good to do the same for these remaining changes.
- Remove need to pass policy and numaNodes as arguments - Remove PolicySingleNUMANode special case check in policy_best_effort - Add mergeProviderHints base to policy_single_numa_node for upcoming commit
Now that PolicySingleNUMANode is not considered here, return defaultAffinity as was the original case before previous bug fix
Explanation taken from original commit: - Change the current method of finding the best hint. Instead of going over all permutations, sort the hints and find the narrowest hint common to all resources. - Break out early when merging to a preferred hint is not possible
@nolancon: The following test failed, say