-
Notifications
You must be signed in to change notification settings - Fork 39.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add instructions about how to bring up e2e test cluster #85836
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure that these headings are accurate:
#### 2a. Create a regular Kubernetes cluster
#### 2b. Create a Kubernetes end-to-end (E2E) test cluster
Is there any difference in the resulting clusters? Can e2e tests be run against clusters brought up using the 2a steps?
I'm wondering if this should instead be:
#### 2. Create a Kubernetes cluster
...explain that there are two ways that work, and explain what the difference between them is...
##### Using
kube-up
##### Using
kubetest
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, did some experiments, the main differences are
cluster/gce/config-test.sh
, so the test scripts look for the e2e cluster only and run tests.Added explanations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also the differences between
kubetest --up
&./hack/e2e-internal/e2e-up.sh
is that kubetest has extra step at the end:./cluster/kubectl.sh --match-server-version=false version
which seems just update the kubectl binary. And the kubectl.sh will be deprecated soon from the file descriptions.