-
Notifications
You must be signed in to change notification settings - Fork 39.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Fix shellcheck failure in log-dump/log-dump.sh" #85858
Conversation
This reverts commit e99a325.
/cc wojtek-t |
/cc BenTheElder dims k-toyoda-pi |
#85753 (comment) seems to point to a specific change, do we need to revert all of the fixes? |
/approve |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, jkaniuk, wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
yes please! |
Thank you for reverting. I'm sorry the commit causes the problem... 😔 |
This reverts commit e99a325.
Probable cause of DumpClusterLogs failures in tests #85753
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fix DumpClusterLogs failures in 5k clusters
Which issue(s) this PR fixes:
Fixes #85753
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/sig cluster-lifecycle
/sig scalability