Kubectl command renaming (run-container to run and resize to scale) #8596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -104,11 +104,11 @@ Objects that contain both spec and status should not contain additional top-leve | |||
| ##### Typical status properties | |||
|
|
|||
| * **phase**: The phase is a simple, high-level summary of the phase of the lifecycle of an object. The phase should progress monotonically. Typical phase values are `Pending` (not yet fully physically realized), `Running` or `Active` (fully realized and active, but not necessarily operating correctly), and `Terminated` (no longer active), but may vary slightly for different types of objects. New phase values should not be added to existing objects in the future. Like other status fields, it must be possible to ascertain the lifecycle phase by observation. Additional details regarding the current phase may be contained in other fields. | |||
| * **conditions**: Conditions represent orthogonal observations of an object's current state. Objects may report multiple conditions, and new types of conditions may be added in the future. Condition status values may be `True`, `False`, or `Unknown`. Unlike the phase, conditions are not expected to be monotonic -- their values may change back and forth. A typical condition type is `Ready`, which indicates the object was believed to be fully operational at the time it was last probed. Conditions may carry additional information, such as the last probe time or last transition time. | |||
| * **conditions**: Conditions represent orthogonal observations of an object's current state. Objects may report multiple conditions, and new types of conditions may be added in the future. Condition status values may be `True`, `False`, or `Unknown`. Unlike the phase, conditions are not expected to be monotonic -- their values may change back and forth. A typical condition type is `Ready`, which indicates the object was believed to be fully operational at the time it was last probed. Conditions may carry additional information, such as the last probe time or last transition time. | |||
There was a problem hiding this comment.
Did anything significant change in this file? If not, please revert it.
There was a problem hiding this comment.
Just empty spaces in the end of the line. should I discard them?
There was a problem hiding this comment.
Yes, please don't make insubstantial changes.
|
Please don't change kubelet. #8319 is only about kubectl. |
|
Dropping kubelet changes. |
|
Please update your pr title with more meaningful information. Thanks! |
andronat
changed the title
|
Put trailing spaces back and rebased to resolve conflicts |
|
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain @ixdy. |
| //0 means that the application is allowed to idle | ||
| MinAutoScaleCount int | ||
|
|
||
| //TargetSelector provides the scaleable target(s). Right now this is a ReplicationController |
|
Great, thanks. LGTM. We need to wait for the e2e test to be fixed before we can merge, unfortunately. |
bgrant0607
added
the
lgtm
|
ok to test |
|
any news on that? It is ready to merge, I rebased it to latest master |
|
needs rebase |
|
done |
thockin
added a commit
that referenced
this pull request
May 27, 2015
Kubectl command renaming (run-container to run and resize to scale)
bgrant0607
added
the
release-note
caesarxuchao
referenced
this pull request
May 30, 2015
k8s-github-robot
pushed a commit
that referenced
this pull request
Aug 23, 2017
Automatic merge from submit-queue (batch tested with PRs 50806, 48789, 49922, 49935, 50438) Remove deprecated kubectl command aliases **What this PR does / why we need it**: These command aliases have been deprecated for more than two years. It's time to remove them. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # ref: #8319 #6118 #8596 **Special notes for your reviewer**: /sig cli **Release note**: ```release-note Remove deprecated kubectl command aliases `apiversions, clusterinfo, resize, rollingupdate, run-container, update` ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #8319
I am not sure about this line: https://github.com/GoogleCloudPlatform/kubernetes/blob/master/pkg/kubectl/cmd/util/factory.go#L96
I also took the liberty to rename RunContainer in kubelet, if it is not needed I can discard it.
/cc @smarterclayton, @ghodss