Update node pages to v1beta3 in web ui #8614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcbroussard
force-pushed
the
v1beta3-nodes
branch
from
ab18b6c
to
6ab0ad3
Compare
|
LGTM. Thanks! |
caesarxuchao
added
the
lgtm
|
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain @ixdy. |
|
why are we receiving this message? @ixdy |
|
rebase please |
|
@dchen1107 will rebase once #8548 goes in |
bcbroussard
force-pushed
the
v1beta3-nodes
branch
from
6ab0ad3
to
a0d455f
Compare
|
rebase please |
bcbroussard
force-pushed
the
v1beta3-nodes
branch
from
a0d455f
to
9ea7199
Compare
|
needs rebase |
bcbroussard
force-pushed
the
v1beta3-nodes
branch
from
9ea7199
to
69160f3
Compare
|
@thockin rebased |
thockin
added a commit
that referenced
this pull request
May 27, 2015
Update node pages to v1beta3 in web ui
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #8304 and #8332
After #8332 lands I'll need do a quick update to one page for v1beta3 support.Update: the changes have been made.
cc @jackgr @lavalamp @bgrant0607 @brendandburns