resize: Enable resource type/name syntax #8618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -65,7 +65,7 @@ func NewCmdResize(f *cmdutil.Factory, out io.Writer) *cobra.Command { | |||
|
|
|||
| func RunResize(f *cmdutil.Factory, out io.Writer, cmd *cobra.Command, args []string) error { | |||
| count := cmdutil.GetFlagInt(cmd, "replicas") | |||
| if len(args) != 2 || count < 0 { | |||
| if count < 0 { | |||
There was a problem hiding this comment.
Need to either handle multiple infos or return an error if there is more than one (down in r.Infos()
Also don't allow more than one objects in commands it makes sense
|
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain @ixdy. |
|
LGTM |
|
ok to test |
smarterclayton
added a commit
that referenced
this pull request
May 22, 2015
resize: Enable resource type/name syntax
smarterclayton
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@smarterclayton fyi