Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove several feature gates in 1.18 #86210

Merged
merged 2 commits into from
Jan 9, 2020
Merged

feat: remove several feature gates in 1.18 #86210

merged 2 commits into from
Jan 9, 2020

Conversation

draveness
Copy link
Contributor

@draveness draveness commented Dec 12, 2019 •
edited by liggitt
Loading

/kind cleanup
/priority backlog
/sig scheduling

Remove several GA features flag in 1.17

The following features are unconditionally enabled and the corresponding `--feature-gates` flags have been removed: `PodPriority`, `TaintNodesByCondition`, `ResourceQuotaScopeSelectors` and `ScheduleDaemonSetPods`

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 12, 2019
@draveness
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 12, 2019
@k8s-ci-robot k8s-ci-robot added the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label Dec 12, 2019
@draveness
Copy link
Contributor Author

/hold cancel

/assign @k82cn @bsalamat @ravisantoshgudimetla

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 13, 2019
@draveness
Copy link
Contributor Author

/assign @kow3ns

@k82cn
Copy link
Member

k82cn commented Dec 14, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 14, 2019
@draveness
Copy link
Contributor Author

/assign @liggitt

@liggitt
Copy link
Member

liggitt commented Jan 9, 2020

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: draveness, k82cn, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2020
@k8s-ci-robot k8s-ci-robot merged commit 3ccdad1 into kubernetes:master Jan 9, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 9, 2020
@chewong chewong mentioned this pull request Jan 10, 2020
Merged
4 tasks
odinuge added a commit to odinuge/test-infra that referenced this pull request Jan 12, 2020
@odinuge
Remove usage of removed feature gate
12ecc3c 
The feature gate was removed in: kubernetes/kubernetes#86210

Running with it results in:

```
unrecognized feature gate: PodPriority
```
@odinuge odinuge mentioned this pull request Jan 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendandburns brendandburns Awaiting requested review from brendandburns

@thockin thockin Awaiting requested review from thockin

Assignees

@liggitt liggitt

@kow3ns kow3ns

@ravisantoshgudimetla ravisantoshgudimetla

@bsalamat bsalamat

@k82cn k82cn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.
7 participants
@draveness @k82cn @liggitt @k8s-ci-robot @kow3ns @ravisantoshgudimetla @bsalamat