Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove several feature gates in 1.18 #86210

Merged
merged 2 commits into from Jan 9, 2020

Conversation

@draveness
Copy link
Member

draveness commented Dec 12, 2019

/kind cleanup
/priority backlog
/sig scheduling

Remove several GA features flag in 1.17

The following features are unconditionally enabled and the corresponding `--feature-gates` flags have been removed: `PodPriority`, `TaintNodesByCondition`, `ResourceQuotaScopeSelectors` and `ScheduleDaemonSetPods`
@draveness

This comment has been minimized.

Copy link
Member Author

draveness commented Dec 12, 2019

/hold

@draveness draveness force-pushed the draveness:feature/remove-ga-flags branch from abb65b1 to 02f335d Dec 12, 2019
@draveness

This comment has been minimized.

Copy link
Member Author

draveness commented Dec 13, 2019

/hold cancel

/assign @k82cn @bsalamat @ravisantoshgudimetla

@draveness

This comment has been minimized.

Copy link
Member Author

draveness commented Dec 13, 2019

/assign @kow3ns

@k82cn

This comment has been minimized.

Copy link
Member

k82cn commented Dec 14, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Dec 14, 2019
@draveness

This comment has been minimized.

Copy link
Member Author

draveness commented Jan 9, 2020

/assign @liggitt

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Jan 9, 2020

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 9, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: draveness, k82cn, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3ccdad1 into kubernetes:master Jan 9, 2020
16 checks passed
16 checks passed
cla/linuxfoundation draveness authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-alpha-features Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 9, 2020
@chewong chewong mentioned this pull request Jan 10, 2020
2 of 4 tasks complete
odinuge added a commit to odinuge/test-infra that referenced this pull request Jan 12, 2020
The feature gate was removed in: kubernetes/kubernetes#86210

Running with it results in:

```
unrecognized feature gate: PodPriority
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can’t perform that action at this time.