-
Notifications
You must be signed in to change notification settings - Fork 38.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs about new Services work #8655
Conversation
|
||
For Kubernetes-native applications, Kubernetes offers a simple `Endpoints` API | ||
that is updated whenever the set of `Pods` in a `Service` changes. For | ||
non-native applications, Kubernetes offers a virtual-IP-based bridge to Services | ||
non-native applications, Kubernetes offers a virtual-IP based bridge to Services |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That hyphen was technically correct, but whatever.
English is right-associative by default, so without the hyphen it's (virtual-IP) (based bridge).
I still see a lot of references to "portal IP". |
### Type = NodePort | ||
|
||
If you set the `type` field to `"NodePort"`, the Kubernetes master will | ||
allocate you a port (from a configured range) for each port exposed by your |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on each node
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done in next push
regarding portal: that hasn't been changed yet. I'll followup Justin's LB changes to see if we can do that reasonably and if so re-update the docs. @justinsb for a read-over to see if I missed anything. |
new push is up |
clients. | ||
|
||
Kubernetes `Service`s support `"TCP"` and `"UDP"` for protocols. The default | ||
is `"TCP`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quotation problem here (missing closing-double quote)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done in next push
new push with nits fixed |
"loadBalancer": { | ||
"ingress": [ | ||
{ | ||
"ip": "146.148.47.155" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have to explain the contents of the ingress field?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mentioned it, I don't feel like we need to go into too much depth here right now.
New push is up with nits addressed |
LGTM outside of existing comments |
Do you want this or #8740 to be merged first? |
This first On Tue, May 26, 2015 at 1:25 PM, Brian Grant notifications@github.com
|
LGTM |
Pushed with a few more "virtual" references removed. |
Update docs about new Services work
@justinsb @vishh @bgrant0607 @jbeda
This should not be committed until Justin's load-balancer rework is in.