Rename "portalIP" to "clusterIP" #8740
Conversation
|
Looking good already. Thanks much. |
|
I like this; it will be much more consistent. |
thockin
force-pushed
the
nix-portal
branch
6 times, most recently
from
4f81bc8
to
0a5d1ea
Compare
thockin
changed the title
|
This depends on the services doc update. Removed WIP - I think it is done. e2e passes (except PD, grr) |
|
FWIW I find it wordy in places but it is consistent. |
|
@zmerlynn @roberthbailey @cjcullen regarding master-run addons and config params in general |
|
Does this require a new kube2sky image to be built once the change goes in on the master side? |
bgrant0607
added
the
release-note
|
Please write a PR description that can be used in the release notes. The flag changes, in particular, are important to anyone whose turnup code isn't in our repo. |
| @@ -128,15 +138,15 @@ Accessing a `Service` without a selector works the same as if it had selector. | |||
| The traffic will be routed to endpoints defined by the user (`1.2.3.4:80` in | |||
| this example). | |||
|
|
|||
| ## Portals and service proxies | |||
| ## Virtual IPs and service proxies | |||
There was a problem hiding this comment.
Possible ways to relate VIPs and cluster IPs:
- Virtual cluster IPs
- Virtual IPs (aka cluster IPs)
- Cluster-local virtual IPs
|
Does this subsume #8655? |
|
@roberthbailey This only changes the v1 API, so kube2sky, other add-ons, configs, examples, etc. don't need to be updated until we move them to v1. |
| applicable for services in general. | ||
| Sometimes you don't need or want load-balancing and a single virtual IP. In | ||
| this case, you can create "headless" services by specifying `"None"` for the | ||
| cluster IP (`spec.clusterIP` or `spec.portalIP` in v1beta3 and earlier APIs). |
There was a problem hiding this comment.
Needs a comma before "or spec.portalIP".
|
Looks pretty good overall. |
|
PR description (first comment) updated. Style question - is "ClusterIP" a noun or is it "Cluster IP". Ditto for "NodePort" vs "Node Port" ? |
|
We're in no way consistent about this, but I'd reserve compound CamelCase (e.g., |
|
LGTM. Please merge #8655 first, which I expect to cause this to need to be rebased. |
bgrant0607
added
the
lgtm
|
Rebased and pushed |
This covers obvious transforms, but not --portal_net, $PORTAL_NET and similar.
Leave old flags but marked as deprecated
Rename "portalIP" to "clusterIP"
Automatic merge from submit-queue (batch tested with PRs 54868, 52547). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Remove deprecated stale flags of kube-apiserver **What this PR does / why we need it**: These flags have been marked as deprecated for more than two years. This PR removes them. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # ref: #8740 **Special notes for your reviewer**: **Release note**: ```release-note action required: Deprecated flags `--portal-net` and `service-node-ports` of kube-apiserver are removed. ```
The term "portal" is confusing to people - we don't need another term for a concept that is closely aligned to one we already know - VIP.
API: Rename the 'portalIP' field to 'clusterIP' in v1 API (v1beta3 and earlier are unchanged)
Flags: Alias the --portal-net flag (on apiserver) to --service-cluster-ip-range. Old flag will continue to work.
Turnup: Rename the PORTAL_NET variable to SERVICE_CLUSTER_IP_RANGE