Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move TaintBasedEvictions feature gates to GA #87487

Merged
merged 1 commit into from
Mar 9, 2020
Merged

Move TaintBasedEvictions feature gates to GA #87487

merged 1 commit into from
Mar 9, 2020

Conversation

Ye-Tian-Zero
Copy link
Contributor

@Ye-Tian-Zero Ye-Tian-Zero commented Jan 23, 2020 •
edited
Loading

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Move TaintBasedEvictions feature gates to GA
Which issue(s) this PR fixes:

Fixes #87428

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Move TaintBasedEvictions feature gates to GA

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/blob/74e610bb0f7e40862688e8a434c77bfafc53cb9e/keps/sig-scheduling/20200114-taint-based-evictions.md

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 23, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @skilxn-go. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 23, 2020
@Ye-Tian-Zero
Copy link
Contributor Author

/sig scheduling

@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 23, 2020
@Ye-Tian-Zero
Copy link
Contributor Author

/assign @mwielgus

@Ye-Tian-Zero
Copy link
Contributor Author

/assign @damemi

@damemi damemi mentioned this pull request Jan 23, 2020
Closed
4 tasks
@damemi
Copy link
Contributor

damemi commented Jan 23, 2020

/ok-to-test

Thanks @skilxn-go! @Huang-Wei, are there any other places this needs to be updated?

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 23, 2020
@Ye-Tian-Zero
Copy link
Contributor Author

/retest

@Huang-Wei
Copy link
Member

are there any other places this needs to be updated?

Here are the things we need to update:

  • featuregate to GA and add a comment indicating that the featuregate will be removed in next release (1.19) - please check other graduated features for reference (e.g., TaintNodeByConditions)
  • cleanup all logic (including tests) related with this featuregate, and ensure CI is green

@skilxn-go It only resolves #87428. Please remove #87161 in the description section. And we should provide a release-note.

@Ye-Tian-Zero
Copy link
Contributor Author

Thanks, I'm going to fix it.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jan 23, 2020
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/test and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 23, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 5, 2020
@Huang-Wei
Copy link
Member

/milestone v1.18

@k8s-ci-robot
Copy link
Contributor

@Huang-Wei: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ahg-g
Copy link
Member

ahg-g commented Mar 5, 2020

/milestone v1.18

@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Mar 5, 2020
@Ye-Tian-Zero
Copy link
Contributor Author

/retest

1 similar comment
@Ye-Tian-Zero
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 6, 2020
@Huang-Wei
Copy link
Member

@skilxn-go can you rebase this PR?

@mattjmcnaughton
Copy link
Contributor

/hold cancel
/sig node
@mattjmcnaughton could you please provide a sig-node signoff for this?

Also, for the other approver sections (#87487 (comment)), if you could please approve:
/assign @deads2k (kube-controller-manager)
/assign @Huang-Wei (scheduling)
/assign @k82cn (nodelifecycle)
/assign @liggitt (api)

(there is not a lot of overlap between the different codepath owners in this PR)

Seeing @derekwaynecarr approved on behalf of sig-node. Thanks Derek!

@Ye-Tian-Zero
Copy link
Contributor Author

@Huang-Wei Sure, I will do it today.

@Ye-Tian-Zero
Copy link
Contributor Author

Ye-Tian-Zero commented Mar 8, 2020 •
edited
Loading

Sorry for my delay, I have some issues on cloning my repo from GitHub. It's extremely slow and fails randomly. I will fix it ASAP.

@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 8, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, derekwaynecarr, Huang-Wei, liggitt, skilxn-go

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ye-Tian-Zero
Copy link
Contributor Author

/retest

@Ye-Tian-Zero
Copy link
Contributor Author

@Huang-Wei It's ok now.

damemi
damemi approved these changes Mar 9, 2020
View reviewed changes
Copy link
Contributor

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
thanks again @skilxn-go

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 9, 2020
@Ye-Tian-Zero
Copy link
Contributor Author

/retest

3 similar comments
@damemi
Copy link
Contributor

damemi commented Mar 9, 2020

/retest

@Ye-Tian-Zero
Copy link
Contributor Author

/retest

@Ye-Tian-Zero
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 0bb125e into kubernetes:master Mar 9, 2020
@AllenXu93 AllenXu93 mentioned this pull request Apr 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haosdent haosdent haosdent left review comments

@Huang-Wei Huang-Wei Huang-Wei left review comments

@damemi damemi damemi approved these changes

@brendandburns brendandburns Awaiting requested review from brendandburns

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@liggitt liggitt

@Huang-Wei Huang-Wei

@damemi damemi

@derekwaynecarr derekwaynecarr

@dchen1107 dchen1107

@deads2k deads2k

@mwielgus mwielgus

@k82cn k82cn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

[TaintBasedEvictions] Clean up featuregate logic