Fix #8373 add kubectl for cluster validation #8752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain @ixdy. |
|
LGTM. |
roberthbailey
added
the
lgtm
|
(running e2e on this won't give any useful results, so not responding to the bot) |
|
@roberthbailey shall we merge? |
|
This works well for me. We need this in trunk 😃 |
saad-ali
added a commit
that referenced
this pull request
May 27, 2015
Fix #8373 add kubectl for cluster validation
|
Thanks @saad-ali for merging. I was mostly AFK today but figured the lgtm label would prompt the oncall to merge the PR for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8373. Tested OK!