Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't show flags in api-versions help #88084

Merged
merged 1 commit into from
Feb 13, 2020
Merged

Don't show flags in api-versions help #88084

merged 1 commit into from
Feb 13, 2020

Conversation

soltysh
Copy link
Contributor

@soltysh soltysh commented Feb 12, 2020

What type of PR is this?
/kind bug

Which issue(s) this PR fixes:
Fixes kubernetes/kubectl#809

Special notes for your reviewer:
/assign @gkarthiks

Does this PR introduce a user-facing change?:

Fix help for api-versions

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 12, 2020
@soltysh
Copy link
Contributor Author

soltysh commented Feb 12, 2020

/sig cli
/assign @sallyom
/priority backlog

@k8s-ci-robot k8s-ci-robot added sig/cli Categorizes an issue or PR as relevant to SIG CLI. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 12, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2020
@sallyom
Copy link
Contributor

sallyom commented Feb 12, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2020
@soltysh
Copy link
Contributor Author

soltysh commented Feb 12, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit c2f08b8 into kubernetes:master Feb 13, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Feb 13, 2020
@soltysh soltysh deleted the issue809 branch March 4, 2020 11:46
wking pushed a commit to wking/kubernetes that referenced this pull request Jul 21, 2020
@k8s-publishing-bot
Merge pull request kubernetes#88084 from soltysh/issue809
a87111c 
Don't show flags in api-versions help

Kubernetes-commit: c2f08b8
@gkarthiks gkarthiks mentioned this pull request Oct 13, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkarthiks gkarthiks gkarthiks approved these changes

@deads2k deads2k Awaiting requested review from deads2k

@eparis eparis Awaiting requested review from eparis

Assignees

@sallyom sallyom

@gkarthiks gkarthiks

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

kubectl api-versions flag options are not clear in the help
4 participants
@soltysh @k8s-ci-robot @sallyom @gkarthiks