Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export Azure Fake Cloud for reusing #88319

Merged
merged 1 commit into from Feb 20, 2020
Merged

Export Azure Fake Cloud for reusing #88319

merged 1 commit into from Feb 20, 2020

Conversation

ZeroMagic
Copy link
Member

@ZeroMagic ZeroMagic commented Feb 19, 2020 •
edited

What type of PR is this?
/kind flake

What this PR does / why we need it:
Via the exported GetTestCloud(), we can reuse the code for the unit tests in Azure related CSI drivers' repo.

Which issue(s) this PR fixes:

Fixes #88298

Special notes for your reviewer:
NONE

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

/sig cloud-provider
/area provider/azure

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. labels Feb 19, 2020
@k8s-ci-robot
Copy link
Contributor

@ZeroMagic: The label(s) kind/test cannot be applied, because the repository doesn't have them

In response to this:

What type of PR is this?
/kind test

What this PR does / why we need it:
Via the exported GetTestCloud(), we can reuse the code for the unit tests in Azure related CSI drivers' repo.

Which issue(s) this PR fixes:

Fixes #88298

Special notes for your reviewer:
NONE

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

/sig cloud-provider
/area provider/azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. kind/flake Categorizes issue or PR as related to a flaky test. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Feb 19, 2020
@andyzhangx
Copy link
Member

/priority important-soon
/sig cloud-provider
/area provider/azure

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 19, 2020
andyzhangx
andyzhangx reviewed Feb 19, 2020
View reviewed changes
staging/src/k8s.io/legacy-cloud-providers/azure/azure_fakes.go
@@ -991,3 +998,54 @@ func (f *fakeVMSet) GetDataDisks(nodeName types.NodeName, crt azcache.AzureCache
func (f *fakeVMSet) GetPowerStatusByNodeName(name string) (string, error) {
return "", fmt.Errorf("unimplemented")
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe could add a comment here: why make this func public

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@andyzhangx
Copy link
Member

/priority important-soon
/sig cloud-provider
/area provider/azure

@andyzhangx
Copy link
Member 

/b/f/w/staging/src/k8s.io/legacy-cloud-providers/azure/azure_test.go:38:2: imported and not used: "k8s.io/kubernetes/vendor/k8s.io/client-go/tools/record"
/b/f/w/staging/src/k8s.io/legacy-cloud-providers/azure/azure_test.go:40:2: imported and not used: "k8s.io/kubernetes/vendor/k8s.io/legacy-cloud-providers/azure/auth"
compilepkg: error running subcommand: exit status 2

@andyzhangx
Copy link
Member

/pony

@k8s-ci-robot
Copy link
Contributor

@andyzhangx: pony image

In response to this:

/pony

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ZeroMagic ZeroMagic force-pushed the azuredisk_fake_test branch 2 times, most recently from a67f387 to 7fd0193 Compare February 19, 2020 12:48
@ZeroMagic
Copy link
Member Author

/test pull-kubernetes-verify

@ZeroMagic
test: export a fake Azure cloud
e2c733a 
Via the exported GetTestCloud(), we can reuse the code for the unit tests in Azure related CSI drivers.

Signed-off-by: ZeroMagic <anthonyliu@zju.edu.cn>
@ZeroMagic
Copy link
Member Author

/retest

@ZeroMagic
Copy link
Member Author

/test pull-kubernetes-e2e-kind
/test pull-kubernetes-e2e-kind-ipv6

1 similar comment
@andyzhangx
Copy link
Member

/test pull-kubernetes-e2e-kind
/test pull-kubernetes-e2e-kind-ipv6

andyzhangx
andyzhangx approved these changes Feb 20, 2020
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 20, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, ZeroMagic

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2020
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

2 similar comments
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 8fb66ae into kubernetes:master Feb 20, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@ritazh ritazh Awaiting requested review from ritazh

Assignees

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

Create Azure Disk Fake operations for testing
4 participants
@ZeroMagic @k8s-ci-robot @andyzhangx @fejta-bot