Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.18] Cleanup CHANGELOG/README.md #88334

Merged
merged 1 commit into from
Feb 27, 2020
Merged

[1.18] Cleanup CHANGELOG/README.md #88334

merged 1 commit into from
Feb 27, 2020
+0 −16

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Feb 19, 2020 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

We have no automatism in place right now to do this automatically, so
we're adapting the CHANGELOG/README.md manually.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?:

None

/cc @kubernetes/release-engineering

@saschagrunert
Cleanup CHANGELOG/README.md for release-1.18 branch
76847b3 
We have no automatism in place right now to do this automatically, so
we're adapting the CHANGELOG/README.md manually.

Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@saschagrunert saschagrunert changed the title Cleanup CHANGELOG/README.md for release-1.18 branch [1.18] Cleanup CHANGELOG/README.md for release-1.18 branch Feb 19, 2020
@saschagrunert saschagrunert changed the title [1.18] Cleanup CHANGELOG/README.md for release-1.18 branch [1.18] Cleanup CHANGELOG/README.md Feb 19, 2020
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 19, 2020
cpanato
cpanato approved these changes Feb 19, 2020
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@justaugustus
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 19, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2020
hasheddan
hasheddan approved these changes Feb 19, 2020
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@saschagrunert
Copy link
Member Author

How do we proceed with the cherrypick-not-approved label? :)

@justaugustus justaugustus added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 27, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Feb 27, 2020
@saschagrunert
Copy link
Member Author

/test pull-kubernetes-e2e-gce

1 similar comment
@saschagrunert
Copy link
Member Author

/test pull-kubernetes-e2e-gce

@k8s-ci-robot k8s-ci-robot merged commit b7d96f4 into kubernetes:release-1.18 Feb 27, 2020
@saschagrunert saschagrunert deleted the changelog-index branch February 27, 2020 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@hasheddan hasheddan hasheddan approved these changes

@justaugustus justaugustus Awaiting requested review from justaugustus

Assignees

@justaugustus justaugustus

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@saschagrunert @justaugustus @k8s-ci-robot @cpanato @hasheddan