Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the unsupported CloudProviderBackoffMode from Azure cloud provider config #88463

Merged
merged 1 commit into from Feb 26, 2020

Conversation

@feiskyer
Copy link
Member

feiskyer commented Feb 24, 2020

What type of PR is this?

/kind cleanup
/sig cloud-provider
/area provider-azure
/priority important-soon

What this PR does / why we need it:

Remove the unsupported CloudProviderBackoffMode from Azure cloud provider config. Since the clients from Azure Go SDK has been reimplemented in cloud provider, CloudProviderBackoffMode is not used anymore.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

cloud provider config CloudProviderBackoffMode has been removed since it won't be used anymore.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


provider config.
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 24, 2020

@feiskyer: The label(s) area/provider-azure cannot be applied, because the repository doesn't have them

In response to this:

What type of PR is this?

/kind cleanup
/sig cloud-provider
/area provider-azure
/priority important-soon

What this PR does / why we need it:

Remove the unsupported CloudProviderBackoffMode from Azure cloud provider config. Since the clients from Azure Go SDK has been reimplemented in cloud provider, CloudProviderBackoffMode is not used anymore.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

cloud provider config CloudProviderBackoffMode has been removed since it won't be used anymore.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feiskyer feiskyer added this to In progress in Provider Azure via automation Feb 24, 2020
@feiskyer

This comment has been minimized.

Copy link
Member Author

feiskyer commented Feb 24, 2020

/milestone v1.18

@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Feb 24, 2020
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 24, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feiskyer

This comment has been minimized.

Copy link
Member Author

feiskyer commented Feb 24, 2020

/assign @andyzhangx
/area provider/azure

// * v2 means only backoff in the Azure SDK is used. In such mode, CloudProviderBackoffDuration and
// CloudProviderBackoffJitter are omitted.
// "default" will be used if not specified.
CloudProviderBackoffMode string `json:"cloudProviderBackoffMode,omitempty" yaml:"cloudProviderBackoffMode,omitempty"`

This comment has been minimized.

Copy link
@andrewsykim

andrewsykim Feb 24, 2020

Member

Is this a breaking change on the config or will this field just be ignored?

This comment has been minimized.

Copy link
@feiskyer

feiskyer Feb 25, 2020

Author Member

this field would be ignored

@smourapina

This comment has been minimized.

Copy link
Member

smourapina commented Feb 26, 2020

Hello @andrewsykim, @feiskyer!
This is Bug Triage for release 1.18 checking in, with a friendly reminder that code freeze is coming in about 1 week (5 March). Is this PR still intended for milestone 1.18?

@feiskyer

This comment has been minimized.

Copy link
Member Author

feiskyer commented Feb 26, 2020

@smourapina yep

ping @andyzhangx for approval

Copy link
Member

andyzhangx left a comment

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Feb 26, 2020
@andyzhangx

This comment has been minimized.

Copy link
Member

andyzhangx commented Feb 26, 2020

/test pull-kubernetes-e2e-aks-engine-azure
try run test again, since pull-kubernetes-e2e-aks-engine-azure test is flacky

@k8s-ci-robot k8s-ci-robot merged commit 20f4b11 into kubernetes:master Feb 26, 2020
18 of 20 checks passed
18 of 20 checks passed
pull-kubernetes-e2e-gce-100-performance Job triggered.
Details
pull-kubernetes-kubemark-e2e-gce-big Job triggered.
Details
cla/linuxfoundation feiskyer authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-aks-engine-azure Job succeeded.
Details
pull-kubernetes-e2e-azure-disk Job succeeded.
Details
pull-kubernetes-e2e-azure-disk-vmss Job succeeded.
Details
pull-kubernetes-e2e-azure-file Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-e2e-kind-ipv6 Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Provider Azure automation moved this from In progress to Done Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.