Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the unsupported CloudProviderBackoffMode from Azure cloud provider config #88463

Merged
merged 1 commit into from
Feb 26, 2020
Merged

Remove the unsupported CloudProviderBackoffMode from Azure cloud provider config #88463

merged 1 commit into from
Feb 26, 2020

Conversation

feiskyer
Copy link
Member

What type of PR is this?

/kind cleanup
/sig cloud-provider
/area provider-azure
/priority important-soon

What this PR does / why we need it:

Remove the unsupported CloudProviderBackoffMode from Azure cloud provider config. Since the clients from Azure Go SDK has been reimplemented in cloud provider, CloudProviderBackoffMode is not used anymore.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

cloud provider config CloudProviderBackoffMode has been removed since it won't be used anymore.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Feb 24, 2020
@k8s-ci-robot
Copy link
Contributor

@feiskyer: The label(s) area/provider-azure cannot be applied, because the repository doesn't have them

In response to this:

What type of PR is this?

/kind cleanup
/sig cloud-provider
/area provider-azure
/priority important-soon

What this PR does / why we need it:

Remove the unsupported CloudProviderBackoffMode from Azure cloud provider config. Since the clients from Azure Go SDK has been reimplemented in cloud provider, CloudProviderBackoffMode is not used anymore.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

cloud provider config CloudProviderBackoffMode has been removed since it won't be used anymore.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 24, 2020
@feiskyer feiskyer added this to In progress in Provider Azure via automation Feb 24, 2020
@feiskyer
Copy link
Member Author

/milestone v1.18

@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Feb 24, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2020
@feiskyer
Copy link
Member Author

/assign @andyzhangx
/area provider/azure

@k8s-ci-robot k8s-ci-robot added the area/provider/azure Issues or PRs related to azure provider label Feb 24, 2020
andrewsykim
andrewsykim reviewed Feb 24, 2020
View reviewed changes
staging/src/k8s.io/legacy-cloud-providers/azure/azure.go
// * v2 means only backoff in the Azure SDK is used. In such mode, CloudProviderBackoffDuration and
// CloudProviderBackoffJitter are omitted.
// "default" will be used if not specified.
CloudProviderBackoffMode string `json:"cloudProviderBackoffMode,omitempty" yaml:"cloudProviderBackoffMode,omitempty"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a breaking change on the config or will this field just be ignored?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this field would be ignored

@smourapina
Copy link

Hello @andrewsykim, @feiskyer!
This is Bug Triage for release 1.18 checking in, with a friendly reminder that code freeze is coming in about 1 week (5 March). Is this PR still intended for milestone 1.18?

@feiskyer
Copy link
Member Author

@smourapina yep

ping @andyzhangx for approval

andyzhangx
andyzhangx approved these changes Feb 26, 2020
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 26, 2020
@andyzhangx
Copy link
Member

/test pull-kubernetes-e2e-aks-engine-azure
try run test again, since pull-kubernetes-e2e-aks-engine-azure test is flacky

@k8s-ci-robot k8s-ci-robot merged commit 20f4b11 into kubernetes:master Feb 26, 2020
Provider Azure automation moved this from In progress to Done Feb 26, 2020
@rfranzke rfranzke mentioned this pull request Mar 26, 2020
Closed
rfranzke added a commit to gardener/gardener-extension-provider-azure that referenced this pull request Apr 8, 2020
@rfranzke
Don't specify deprecated backoff mode for 1.18+
56d2c46 
See also: kubernetes/kubernetes#88463
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsykim andrewsykim andrewsykim left review comments

@andyzhangx andyzhangx andyzhangx approved these changes

@aramase aramase Awaiting requested review from aramase

@justaugustus justaugustus Awaiting requested review from justaugustus

Assignees

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Provider Azure
  
Done
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@feiskyer @k8s-ci-robot @smourapina @andyzhangx @andrewsykim