-
Notifications
You must be signed in to change notification settings - Fork 38.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a new filter goaway which could send GOAWAY probabilistically to help balance HTTP2 requests #88567
add a new filter goaway which could send GOAWAY probabilistically to help balance HTTP2 requests #88567
Conversation
Hi @answer1991. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/hold let me do some more test firstly |
039fe87
to
9da54e3
Compare
9da54e3
to
cf8a84f
Compare
/hold cancel The testing result is awesome. After client received GOAWAY, the in-flight watch request will NOT be influenced, and the new requests will use a new TCP connection, which means load-balance will work after client receive GOAWAY. Please see details and result in my test cases. |
cf8a84f
to
15c42cc
Compare
15c42cc
to
dd074e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Can you edit the release note to speak about the flag rather than the filter? Thanks. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: answer1991, lavalamp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
updated release note. /hold cancel |
Merge progress seems blocked, let me fix the validating error message nit and push again to trigger the merge progress |
c8c86ef
to
81f46b6
Compare
@lavalamp kindly ping for a BTW, fix the validating error message nit.
Not sure how to config the e2e API Server flags. |
/lgtm |
Can I set it up for different resources? |
It's a HTTP filter and not care about resources. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
API Server and client use HTTP2 to connect each other, which means client always hit the same API Server across different request and the requests are NOT balanced even if we use a load-balance to expose API Server.
With this PR merged, a new filter
goaway
could send GOAWAY to HTTP2 client probabilistically. After client received GOAWAY, the in-flight watch request will NOT be influenced, and the new requests will use a new TCP connection, which means load-balance will work after client receive GOAWAYWhich issue(s) this PR fixes:
None
Special notes for your reviewer:
Nothing yet.
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
None