Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX SRIOV detection logic not to error out if device not present on the system #88721

Merged
merged 1 commit into from Mar 5, 2020
Merged

FIX SRIOV detection logic not to error out if device not present on the system #88721

merged 1 commit into from Mar 5, 2020

Conversation

Deepthidharwar
Copy link
Contributor

@Deepthidharwar Deepthidharwar commented Mar 2, 2020 •
edited

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind bug

What this PR does / why we need it:
This PR does not report an error if SRIOV device is not found on the system. Therefore, with this fix we can go ahead and run topology policy changes e2e tests without erring out.

Which issue(s) this PR fixes:

Fixes

Special notes for your reviewer:
Currently #88566 is failing to run e2e topology manager tests because of this bug.

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 2, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @Deepthidharwar. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Deepthidharwar Deepthidharwar mentioned this pull request Mar 2, 2020
Merged
@ffromani
Copy link
Contributor

ffromani commented Mar 2, 2020

lgtm. I'd probably pushed this fix on top of your #88566, but it's fine both ways.

@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 2, 2020
vpickard
vpickard reviewed Mar 2, 2020
View reviewed changes
test/e2e_node/topology_manager_test.go
@@ -170,9 +170,7 @@ func findNUMANodeWithoutSRIOVDevicesFromSysfs(numaNodes int) (int, bool) {
}

if len(pciPerNuma) == 0 {
// if we got this far we already passed a rough check that SRIOV devices
// are available in the box, so something is seriously wrong
framework.Failf("failed to find any VF devices from %v", pciDevs)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be good to have some kind of log here to help us know that we hit this condition.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@Deepthidharwar
Currently SRIOV detection logic is reporting error if it fails to det…
a4b59a5 
…ect SRIOV device

on the system. This patch aims to fix the same.

Signed-off-by: Deepthi Dharwar <ddharwar@redhat.com>
@nolancon
Copy link

nolancon commented Mar 2, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 2, 2020
@ffromani
Copy link
Contributor

ffromani commented Mar 2, 2020

/test pull-kubernetes-e2e-gce

@rphillips
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 3, 2020
@rphillips
Copy link
Member

/assign @derekwaynecarr

@derekwaynecarr
Copy link
Member

test should exit gracefully rather than fail if run on environment that lacked a device.

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Deepthidharwar, derekwaynecarr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2020
@derekwaynecarr derekwaynecarr mentioned this pull request Mar 5, 2020
Merged
@Deepthidharwar
Copy link
Contributor Author

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Mar 5, 2020
@Deepthidharwar
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 67c6767 into kubernetes:master Mar 5, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Mar 5, 2020
@vpickard vpickard mentioned this pull request May 21, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpickard vpickard vpickard left review comments

@mtaufen mtaufen Awaiting requested review from mtaufen

@tallclair tallclair Awaiting requested review from tallclair

Assignees

@rphillips rphillips

@derekwaynecarr derekwaynecarr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Deepthidharwar @k8s-ci-robot @ffromani @nolancon @rphillips @derekwaynecarr @vpickard