Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing ConfigMap as suggestion for IngressClass parameters #89093

Merged
merged 1 commit into from
Mar 13, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/openapi-spec/swagger.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 3 additions & 4 deletions pkg/apis/networking/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -297,10 +297,9 @@ type IngressClassSpec struct {
// "acme.io/ingress-controller". This field is immutable.
Controller string

// Parameters is a link to a resource containing additional configuration
// for the controller. This is optional if the controller does not require
// extra parameters. Example configuration resources include
// `core.ConfigMap` or a controller specific Custom Resource.
// Parameters is a link to a custom resource containing additional
// configuration for the controller. This is optional if the controller does
// not require extra parameters.
// +optional
Parameters *api.TypedLocalObjectReference
}
Expand Down
7 changes: 3 additions & 4 deletions staging/src/k8s.io/api/networking/v1beta1/generated.proto

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 3 additions & 4 deletions staging/src/k8s.io/api/networking/v1beta1/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -298,10 +298,9 @@ type IngressClassSpec struct {
// "acme.io/ingress-controller". This field is immutable.
Controller string `json:"controller,omitempty" protobuf:"bytes,1,opt,name=controller"`

// Parameters is a link to a resource containing additional configuration
// for the controller. This is optional if the controller does not require
// extra parameters. Example configuration resources include
// `core.ConfigMap` or a controller specific Custom Resource.
// Parameters is a link to a custom resource containing additional
// configuration for the controller. This is optional if the controller does
// not require extra parameters.
// +optional
Parameters *v1.TypedLocalObjectReference `json:"parameters,omitempty" protobuf:"bytes,2,opt,name=parameters"`
}
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.