-
Notifications
You must be signed in to change notification settings - Fork 39k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing ConfigMap as suggestion for IngressClass parameters #89093
Removing ConfigMap as suggestion for IngressClass parameters #89093
Conversation
As this is a a local object reference from a global object, referencing a ConfigMap would not be possible. Controller specific custom resources are a much better fit here, allowing for better validation.
/priority critical-urgent |
Thanks to @alexgervais for catching this! |
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
/test pull-kubernetes-e2e-kind-ipv6 |
/lgtm |
agree we should not tell people to reference an object that would be impossible for them to reference /milestone v1.18 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bowei, liggitt, robscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
/retest Review the full test history for this PR. Silence the bot with an |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
As this is a a local object reference from a global object, referencing a ConfigMap would not be possible. Controller specific custom resources are a much better fit here, allowing for better validation.
Special notes for your reviewer:
I'd like to get this into the 1.18 milestone if possible. This is just a docs change, but could help avoid some confusion.
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/sig network
/cc @cmluciano
/assign @bowei @liggitt