New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correctly parse X-Stream-Protocol-Version header #89857
Conversation
/cc @liggitt |
I would suggest putting the []string -> []string transform into its own function, unit testing it, then just doing something like:
|
@liggitt |
/priority important-soon |
Signed-off-by: Ted Yu <yuzhihong@gmail.com>
/test pull-kubernetes-e2e-gce |
@tedyu: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, tedyu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…f-#89857-upstream-release-1.18 Automated cherry pick of #89857: Correctly parse X-Stream-Protocol-Version header
…f-#89857-upstream-release-1.17 Automated cherry pick of #89857: Correctly parse X-Stream-Protocol-Version header
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR iterates the components of X-Stream-Protocol-Version header and splits each by comma.
Non-empty protocol versions take part in negotiation.
Which issue(s) this PR fixes:
Fixes #89849
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: