Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update kubernetes to klog v2 #90183

Merged
merged 26 commits into from May 17, 2020
Merged

Update kubernetes to klog v2 #90183

merged 26 commits into from May 17, 2020

Conversation

dims
Copy link
Member

@dims dims commented Apr 15, 2020 •
edited

Reviews

sig-auth:

  • golang.org/x/oauth2

sig-instrumentation

  • github.com/go-logr/logr
  • go.opencensus.io
  • k8s.io/klog/v2

sig-apimachinery:

  • k8s.io/kube-openapi
  • k8s.io/gengo

sig-node:

  • github.com/google/cadvisor
  • github.com/golang/groupcache

sig-cloudprovider:

  • cloud.google.com/go
  • github.com/googleapis/gax-go
  • github.com/GoogleCloudPlatform/k8s-cloud-provider
  • google.golang.org/api
  • sigs.k8s.io/apiserver-network-proxy

Miscellaneous:

  • k8s.io/utils

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
klog v2 has the new APIs needed for the structured logging KEP

Which issue(s) this PR fixes:

Fixes #89961

Special notes for your reviewer:

New Dependencies

  • github.com/go-logr/logr
  • github.com/googleapis/gax-go/v2

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/apiserver area/cloudprovider area/code-generation area/conformance Issues or PRs related to kubernetes conformance tests area/dependency Issues or PRs related to dependency changes labels Apr 15, 2020
@k8s-ci-robot k8s-ci-robot requested review from brahmaroutu, dashpole and a team April 15, 2020 20:57
@k8s-ci-robot k8s-ci-robot added area/kubectl area/kubelet area/release-eng Issues or PRs related to the Release Engineering subproject sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/release Categorizes an issue or PR as relevant to SIG Release. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 15, 2020
@dims dims changed the title Update kubernetes to klog v2 [WIP] Update kubernetes to klog v2 Apr 15, 2020
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 15, 2020
@dims dims force-pushed the update-kubernetes-to-klog-v2 branch from 5db7201 to 8608ff6 Compare April 15, 2020 21:47
@dims dims changed the title [WIP] Update kubernetes to klog v2 Update kubernetes to klog v2 Apr 15, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 15, 2020
dims added 7 commits May 16, 2020 07:53
@dims
Updating dependency golang.org/x/mobile to version v0.0.0-20190719004…
e3a1dde 
…257-d2bd2a29d028

Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@dims
Updating dependency golang.org/x/mod to version v0.1.0
3992c86 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@dims
Fix for API change in cadvisor
9006b2d 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@dims
switch over k/k to use klog v2
442a69c 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@dims
Drop tests that break with newer oauth2
eea0fea 
The bazel test failures are caused by (oauth2: turn Transport.CancelRequest into a no-op)[golang/oauth2@858c2ad]:
golang/oauth2@0f29369...858c2ad

Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@dims
fix API change in apiserver-network-proxy
ce6292f 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@dims
Run hack/update-vendor.sh
07d8861 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@dims dims force-pushed the update-kubernetes-to-klog-v2 branch from 34472ac to 07d8861 Compare May 16, 2020 11:54
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 16, 2020
@dims
Copy link
Member Author

dims commented May 16, 2020 •
edited

@neolit123 @liggitt can one of you please reapply lgtm? I had to rebase.

@liggitt
Copy link
Member

liggitt commented May 16, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 16, 2020
@dims
Copy link
Member Author

dims commented May 16, 2020

good morning @liggitt !!

@dims
Copy link
Member Author

dims commented May 16, 2020

/test pull-kubernetes-e2e-gce
/test pull-kubernetes-verify

@liggitt
Copy link
Member

liggitt commented May 16, 2020

/skip

@dims
Copy link
Member Author

dims commented May 16, 2020

/test pull-kubernetes-conformance-kind-ga-only-parallel

@liggitt
Copy link
Member

liggitt commented May 16, 2020

Hmm

The pod could not start because it could not mount the volume "gcs-credentials": couldn't propagate object cache: timed out waiting for the condition

@liggitt
Copy link
Member

liggitt commented May 16, 2020

/retest

@dims
Copy link
Member Author

dims commented May 16, 2020

/test pull-kubernetes-e2e-kind
/test pull-kubernetes-integration

@liggitt
Copy link
Member

liggitt commented May 16, 2020

The pod could not start because it could not mount the volume "gcs-credentials": couldn't propagate object cache: timed out waiting for the condition

Saw this again. @BenTheElder, this ring a bell?

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 16, 2020 •
edited

@dims: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-iscsi 07d8861 link /test pull-kubernetes-e2e-gce-iscsi
pull-kubernetes-e2e-kind-ipv6 07d8861 link /test pull-kubernetes-e2e-kind-ipv6
pull-kubernetes-conformance-kind-ipv6-parallel 07d8861 link /test pull-kubernetes-conformance-kind-ipv6-parallel
pull-kubernetes-e2e-gci-gce-ipvs 07d8861 link /test pull-kubernetes-e2e-gci-gce-ipvs
pull-kubernetes-e2e-gce-storage-snapshot 07d8861 link /test pull-kubernetes-e2e-gce-storage-snapshot

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dims
Copy link
Member Author

dims commented May 16, 2020

/test pull-kubernetes-e2e-kind
/test pull-kubernetes-integration

@k8s-ci-robot k8s-ci-robot merged commit b170451 into kubernetes:master May 17, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone May 17, 2020
@seanmalloy seanmalloy mentioned this pull request May 20, 2020
Closed
@abhiraut abhiraut mentioned this pull request May 21, 2020
Closed
@github-actions github-actions bot mentioned this pull request May 27, 2020
Closed
@hzliangbin hzliangbin mentioned this pull request Jun 15, 2020
Closed
@krmayankk
Copy link

@dims so which of the kubernetes components moved to json or is this just moving from klog to klog v2 and the json apis will be used selectively later ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@liggitt liggitt liggitt left review comments

@dashpole dashpole dashpole left review comments

@brahmaroutu brahmaroutu Awaiting requested review from brahmaroutu

@logicalhan logicalhan Awaiting requested review from logicalhan

Assignees

@neolit123 neolit123

@liggitt liggitt

@serathius serathius

@derekwaynecarr derekwaynecarr

@enj enj

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/code-generation area/conformance Issues or PRs related to kubernetes conformance tests area/dependency Issues or PRs related to dependency changes area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/ipvs area/kubeadm area/kubectl area/kubelet area/provider/gcp Issues or PRs related to gcp provider area/release-eng Issues or PRs related to the Release Engineering subproject area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

Upgrade to klogv2