Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add prerelease lifecycle tags to policy #90603

Merged
merged 1 commit into from May 5, 2020
Merged

add prerelease lifecycle tags to policy #90603

merged 1 commit into from May 5, 2020

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Apr 29, 2020

This adds the lifecycle annotation tags matching https://github.com/kubernetes/enhancements/blob/master/keps/sig-architecture/1635-prevent-permabeta/README.md

The clock is set for deprecation in 1.22 and removal of beta levels in 1.25.

/kind cleanup
/priority important-soon
@kubernetes/sig-node-api-reviews

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 29, 2020
@deads2k
Copy link
Contributor Author

deads2k commented Apr 29, 2020

@kubernetes/sig-node-api-reviews @kubernetes/sig-scheduling-api-reviews @kubernetes/sig-apps-api-reviews for PDB and eviction

@kubernetes/sig-auth-api-reviews for PSP

@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. labels Apr 29, 2020
@deads2k
Copy link
Contributor Author

deads2k commented Apr 29, 2020

@mortent I got pointed to kubernetes/enhancements#1502 . I wanted to make sure you saw this PR aligning the API lifecycle tags to the beta policy.

@mortent
Copy link
Member

mortent commented Apr 29, 2020

@deads2k Thanks for the heads up.

@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@liggitt
Copy link
Member

liggitt commented Apr 29, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 29, 2020
@liggitt
Copy link
Member

liggitt commented Apr 30, 2020

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deads2k
Copy link
Contributor Author

deads2k commented May 4, 2020

/test all

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

3 similar comments
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit b48f5af into kubernetes:master May 5, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone May 5, 2020
@jessehu
Copy link

jessehu commented May 20, 2020

Hi @deads2k @liggitt, since PSP API will be deprecated in 1.22 and removed 1.25, what's the replacement and plan? Thanks.

@neolit123 neolit123 mentioned this pull request May 29, 2020
Closed
@jeanluclariviere
Copy link

I would also be curious to know what will be replacing PSPs

@enj
Copy link
Member

enj commented Jun 2, 2020

@jessehu @jeanluclariviere see kubernetes/website#20789 for the details.

cc @tallclair

@enj enj mentioned this pull request Jun 16, 2020
Closed
@dprotaso dprotaso mentioned this pull request Jun 29, 2020
Closed
This was referenced Jul 9, 2020
Closed
Closed
Closed
Closed
Closed
sayboras added a commit to sayboras/cilium that referenced this pull request Jul 9, 2020
@sayboras
chore(cleanup): To cleanup PSP related files or changes
fe99ec4 
As PSP will be removed from k8s upstream
(kubernetes/kubernetes#90603), any psp related
changes in codebase can be cleaned up.

Closes cilium#12468

Signed-off-by: Tam Mach <sayboras@yahoo.com>
@sayboras sayboras mentioned this pull request Jul 9, 2020
Merged
@mlbiam mlbiam mentioned this pull request Jul 9, 2020
Closed
7 tasks
nebril pushed a commit to cilium/cilium that referenced this pull request Jul 10, 2020
@sayboras @nebril
chore(cleanup): To cleanup PSP related files or changes
c78b1f9 
As PSP will be removed from k8s upstream
(kubernetes/kubernetes#90603), any psp related
changes in codebase can be cleaned up.

Closes #12468

Signed-off-by: Tam Mach <sayboras@yahoo.com>
@aanm aanm mentioned this pull request Jul 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt Awaiting requested review from liggitt

@mbohlool mbohlool Awaiting requested review from mbohlool

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@deads2k @mortent @fejta-bot @liggitt @k8s-ci-robot @jessehu @jeanluclariviere @enj