Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cleanup): To cleanup PSP related files or changes #12469

Merged
merged 1 commit into from
Jul 10, 2020

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented Jul 9, 2020

As PSP will be removed from k8s upstream
(kubernetes/kubernetes#90603), any psp related
changes in codebase can be cleaned up.

Closes #12468

Signed-off-by: Tam Mach sayboras@yahoo.com

Remove PodSecurityPolicy in helm due to deprecation and future removal in Kubernetes

@maintainer-s-little-helper
Copy link

Commit ca18db6ac54e28c90025c56e10e6fe1ee823a92e does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jul 9, 2020
@aanm aanm added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Jul 9, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 9, 2020
As PSP will be removed from k8s upstream
(kubernetes/kubernetes#90603), any psp related
changes in codebase can be cleaned up.

Closes cilium#12468

Signed-off-by: Tam Mach <sayboras@yahoo.com>
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Jul 9, 2020
@sayboras sayboras marked this pull request as ready for review July 9, 2020 08:38
@sayboras sayboras requested review from a team as code owners July 9, 2020 08:38
@sayboras sayboras requested a review from a team July 9, 2020 08:38
Copy link
Member

@aanm aanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a release note to the PR

@sayboras sayboras changed the title cleanup(psp): cleanup psp related files chore(cleanup): To cleanup PSP related files or changes Jul 9, 2020
@coveralls
Copy link

coveralls commented Jul 9, 2020

Coverage Status

Coverage decreased (-0.004%) to 36.933% when pulling fe99ec4 on sayboras:feature/remove-psp into 9f87750 on cilium:master.

@aanm
Copy link
Member

aanm commented Jul 9, 2020

test-me-please

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 10, 2020
@nebril nebril merged commit c78b1f9 into cilium:master Jul 10, 2020
@aanm aanm mentioned this pull request Sep 28, 2020
@sayboras sayboras deleted the feature/remove-psp branch January 10, 2022 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

psp: remove changes related to psp
6 participants