fix some fixture path calculations #90872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
mikedanese
added
the
priority/important-longterm
k8s-ci-robot
added
area/apiserver
sig/api-machinery
liggitt
reviewed
May 12, 2020
staging/src/k8s.io/apiextensions-apiserver/pkg/cmd/server/testing/testserver.go
Show resolved
Hide resolved
|
add a comment and a log message, then lgtm |
mikedanese
force-pushed
the
integ
branch
2 times, most recently
from
a711ac8
to
0deb7bd
Compare
Current calculations assume that -trimpath is not passed to go tool compile, which is not the case for test binaries built with bazel. This causes issues for integration tests right now but is generally not correct. The approach taken here is a bit of a hack but it works on the assumption that if and only if trimpath is passed, we are running under bazel. I didn't see a good spot for pkgPath(), so I just copied it around.
|
/retest |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, mikedanese The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current calculations assume that -trimpath is not passed to go tool
compile, which is not the case for test binaries built with bazel. This
causes issues for integration tests right now but is generally not
correct.
The approach taken here is a bit of a hack but it works on the
assumption that if and only if trimpath is passed, we are running under
bazel. I didn't see a good spot for pkgPath(), so I just copied it
around.
/kind bug
/sig testing