Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Update bazel to 3.4.1 and k/repo-infra to v0.2.0 #96011

Merged
merged 3 commits into from Jan 8, 2021
Merged

build: Update bazel to 3.4.1 and k/repo-infra to v0.2.0 #96011

merged 3 commits into from Jan 8, 2021

Conversation

mikedanese
Copy link
Member

@mikedanese mikedanese commented Oct 29, 2020 •
edited by justaugustus

build: Update bazel to 3.4.1 and k/repo-infra to v0.2.0
Needed for Golang 1.16 updates: kubernetes/release#1834

/kind cleanup
/sig release

NONE

@mikedanese mikedanese self-assigned this Oct 29, 2020
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Oct 29, 2020
@k8s-ci-robot
Copy link
Contributor

@mikedanese: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 29, 2020
@mikedanese
Copy link
Member Author

/retest

@mikedanese
Copy link
Member Author

/test pull-kubernetes-bazel-test-canary

1 similar comment
@mikedanese
Copy link
Member Author

/test pull-kubernetes-bazel-test-canary

@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2020
@mikedanese
Copy link
Member Author

/test pull-kubernetes-bazel-test-canary

@mikedanese mikedanese assigned justaugustus and unassigned mikedanese Nov 3, 2020
@mikedanese
Copy link
Member Author

/retest

@mikedanese
Copy link
Member Author

I don't think we need this until after code freeze, but I'll let @justaugustus say when.

cc @BenTheElder @fejta

@dims
Copy link
Member

dims commented Nov 3, 2020

/retitle WIP: bump bazel to 3.4.1

@k8s-ci-robot k8s-ci-robot changed the title bump bazel to 3.4.1 WIP: bump bazel to 3.4.1 Nov 3, 2020
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 3, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2020
@mikedanese mikedanese added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 3, 2020
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 7, 2021
@mikedanese
fixup fixture logic
7726137 
There was a bug with init() but it was resolved in
bazelbuild/rules_go#2696

Changed to match other fixture methods.

Change-Id: I882b8535e5c5c117fb10c41d34c8eed1ccdb74bb
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 7, 2021
mikedanese
mikedanese commented Jan 7, 2021
View reviewed changes
staging/src/k8s.io/legacy-cloud-providers/vsphere/vclib/fixtures/fixtures.go
//
// The approach taken here works for both go test and bazel on the assumption
// that if and only if trimpath is passed, we are running under bazel.
func pkgPath() (string, error) {
Copy link
Member Author

@mikedanese mikedanese Jan 7, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is copied from #90872. There was a bug fix to data loading in init() that was resolved in bazelbuild/rules_go#1918. This ~removes the workaround.

@k8s-ci-robot k8s-ci-robot added area/cloudprovider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 7, 2021
@mikedanese
Copy link
Member Author

/retest

@mikedanese
Copy link
Member Author

For staging/src/k8s.io/legacy-cloud-providers/vsphere/vclib/fixtures/fixtures.go change:

/assign @andrewsykim

@justaugustus
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2021
@dims
Copy link
Member

dims commented Jan 8, 2021

/approve

(For code organization / dependency updates only) :)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, justaugustus, mikedanese

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2021
@dims
Copy link
Member

dims commented Jan 8, 2021

/hold

( for @andrewsykim )

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 8, 2021
@justaugustus justaugustus changed the title bump bazel to 3.4.1 build: Update bazel to 3.4.1 and k/repo-infra to v0.2.0 Jan 8, 2021
@justaugustus justaugustus mentioned this pull request Jan 8, 2021
Closed
21 tasks
andrewsykim
andrewsykim reviewed Jan 8, 2021
View reviewed changes
Copy link
Member

@andrewsykim andrewsykim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for staging/src/k8s.io/legacy-cloud-providers/vsphere/vclib/fixtures/fixtures.go

@justaugustus
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 8, 2021
@justaugustus
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit 0fe6f72 into kubernetes:master Jan 8, 2021
@justaugustus
Copy link
Member

Awesome work, @mikedanese!!!

@mikedanese mikedanese deleted the bazel branch January 8, 2021 18:03
@Rajalakshmi-Girish Rajalakshmi-Girish mentioned this pull request Jan 11, 2021
Merged
@liggitt liggitt mentioned this pull request Jan 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsykim andrewsykim andrewsykim left review comments

@justaugustus justaugustus Awaiting requested review from justaugustus

Assignees

@justaugustus justaugustus

@andrewsykim andrewsykim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mikedanese @k8s-ci-robot @dims @MushuEE @BenTheElder @justaugustus @andrewsykim