Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #91184: Azure: support non-VMSS instances removal #91200

Commits on May 18, 2020

  1. Azure: support non-VMSS instances removal

    When called by Controller Manager lifecycle controller for a node missing
    heartbeats (via `InstanceShutdownByProviderID()`), Azure cloud provider
    ensures the instance backing that node is shut down or otherwise removed from
    its containing VMSS before allowing the node to be reaped from the cluster.
    
    But it won't test the same for VMAS or standalone instances (not part of a
    VMSS), which are otherwise well supported: they can register, for instance.
    So deleted non-VMSS instances will leave `NotReady` nodes behind, and,
    depending on their name, might cause regular VMSS List / full re-scans.
    
    fix build failure
    bpineau authored and andyzhangx committed May 18, 2020
    Copy the full SHA
    89fe5cb View commit details
    Browse the repository at this point in the history