Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to use CRI-O as runtime in kube-up (on Ubuntu for now) #91209

Closed
wants to merge 1 commit into from

Conversation

saschagrunert
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

Analogous to containerd, we also need a job that uses CRI-O, both in
master and node. This PR enables us to install CRI-O automatically
when we use a ubuntu OS base image if it is not present on the image.
This also enables us to inject newer versions of containerd and runc to
help us test against them as well.

Which issue(s) this PR fixes:

Refers to #87931, kubernetes/test-infra#16589

Special notes for your reviewer:

cc @dims @aojea @mrunalp

Does this PR introduce a user-facing change?:

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 18, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: saschagrunert
To complete the pull request process, please assign wojtek-t
You can assign the PR to them by writing /assign @wojtek-t in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from mml and mwielgus May 18, 2020 14:17
@k8s-ci-robot k8s-ci-robot added area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 18, 2020
Analogous to containerd, we also need a job that uses CRI-O, both in
master and node. This PR enables us to install CRI-O automatically
when we use a ubuntu OS base image if it is not present on the image.
This also enables us to inject newer versions of containerd and runc to
help us test against them as well.

Signed-off-by: Sascha Grunert <sgrunert@suse.com>
make install -C "crio-$UBUNTU_INSTALL_CRIO_VERSION"

systemctl daemon-reload
systemctl start crio
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this mean we can have crio and containerd run at the same time?
may this cause a conflict or can both run at the same time?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they can run in parallel, yes. Never actually tried it but running docker on CRI-O nodes should work too.

@haircommander
Copy link
Contributor

@saschagrunert, @harche was also doing work in this space. maybe y'all can work together to get this through?

@harche
Copy link
Contributor

harche commented May 19, 2020

Hi @saschagrunert, I have a WIP PR in test-infra for adding presubmit job for crio. Considering the recently merged support for cgroups v2, we are hoping to run those tests on Fedora 31+ node. @vpickard is helping me to identify a gcp proejct which can host Fedora 31 image (gcp doesn't have publicly available fedora images).

As of now there are no presubmit or periodic CRIO tests in test-infra.

@saschagrunert
Copy link
Member Author

Hi @saschagrunert, I have a WIP PR in test-infra for adding presubmit job for crio. Considering the recently merged support for cgroups v2, we are hoping to run those tests on Fedora 31+ node. @vpickard is helping me to identify a gcp proejct which can host Fedora 31 image (gcp doesn't have publicly available fedora images).

As of now there are no presubmit or periodic CRIO tests in test-infra.

Alright is there anything I can do or should we close this one?

@harche
Copy link
Contributor

harche commented May 19, 2020

@saschagrunert no need to close this one.

Maybe we can work together, on adding a crio presubmit job using ubuntu. I already have WIP PR for fedora based job, but we can collaborate and co-author that PR to have both Fedora and Ubuntu based presubmit jobs for CRIO if you wish.

Let me know what do you think.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 17, 2020
@saschagrunert
Copy link
Member Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 18, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 16, 2020
@k8s-ci-robot
Copy link
Contributor

@saschagrunert: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@saschagrunert
Copy link
Member Author

Let's close this for now, I think we're moving into a different direction.

@saschagrunert saschagrunert deleted the crio-e2e branch November 16, 2020 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants