New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to use CRI-O as runtime in kube-up (on Ubuntu for now) #91209
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Analogous to containerd, we also need a job that uses CRI-O, both in master and node. This PR enables us to install CRI-O automatically when we use a ubuntu OS base image if it is not present on the image. This also enables us to inject newer versions of containerd and runc to help us test against them as well. Signed-off-by: Sascha Grunert <sgrunert@suse.com>
make install -C "crio-$UBUNTU_INSTALL_CRIO_VERSION" | ||
|
||
systemctl daemon-reload | ||
systemctl start crio |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this mean we can have crio and containerd run at the same time?
may this cause a conflict or can both run at the same time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think they can run in parallel, yes. Never actually tried it but running docker on CRI-O nodes should work too.
@saschagrunert, @harche was also doing work in this space. maybe y'all can work together to get this through? |
Hi @saschagrunert, I have a WIP PR in As of now there are no |
Alright is there anything I can do or should we close this one? |
@saschagrunert no need to close this one. Maybe we can work together, on adding a crio presubmit job using Let me know what do you think. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@saschagrunert: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Let's close this for now, I think we're moving into a different direction. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Analogous to containerd, we also need a job that uses CRI-O, both in
master and node. This PR enables us to install CRI-O automatically
when we use a ubuntu OS base image if it is not present on the image.
This also enables us to inject newer versions of containerd and runc to
help us test against them as well.
Which issue(s) this PR fixes:
Refers to #87931, kubernetes/test-infra#16589
Special notes for your reviewer:
cc @dims @aojea @mrunalp
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: