Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set weight of PodTopologySpread Score to 2 #91258

Merged
merged 1 commit into from
May 20, 2020
Merged

Set weight of PodTopologySpread Score to 2 #91258

merged 1 commit into from
May 20, 2020

Conversation

alculquicondor
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

Double weight of PodTopologySpread Score, because:

  • This is a score coming from user preference.
  • It makes its signal comparable to NodeResourcesLeastAllocated.

Which issue(s) this PR fixes:

Fixes #88174

Does this PR introduce a user-facing change?:

Weight of PodTopologySpread scheduling Score is doubled.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 19, 2020
@alculquicondor
Copy link
Member Author

/assign @ahg-g

@alculquicondor
Copy link
Member Author

/priority important-backlog

@k8s-ci-robot
Copy link
Contributor

@alculquicondor: The label(s) priority/important-backlog cannot be applied, because the repository doesn't have them

In response to this:

/priority important-backlog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 19, 2020
@alculquicondor
Copy link
Member Author

/priority important-longterm

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 19, 2020
@ahg-g
Copy link
Member

ahg-g commented May 19, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 19, 2020
@alculquicondor
Set weight of PodTopologySpread Score to 2
9819b25 
Signed-off-by: Aldo Culquicondor <acondor@google.com>
@alculquicondor
Copy link
Member Author

Fixed test

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 19, 2020
@ahg-g
Copy link
Member

ahg-g commented May 19, 2020

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 19, 2020
@alculquicondor
Copy link
Member Author

/retest

@alculquicondor alculquicondor mentioned this pull request May 19, 2020
Closed
@alculquicondor
Copy link
Member Author

cc @prameshj

@alculquicondor
Copy link
Member Author

/retest

@Huang-Wei
Copy link
Member

LGTM. Glad to see this happen.

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 7ba332a into kubernetes:master May 20, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone May 20, 2020
@spiffxp spiffxp mentioned this pull request May 21, 2020
Closed
@spiffxp
Copy link
Member

spiffxp commented May 21, 2020

This may have caused #91316

@github-actions github-actions bot mentioned this pull request May 27, 2020
Closed
This was referenced May 29, 2020
Closed
Merged
Merged
@alculquicondor alculquicondor mentioned this pull request Jun 9, 2020
Merged
@jarrpa jarrpa mentioned this pull request Aug 26, 2020
Merged
@Huang-Wei Huang-Wei mentioned this pull request Apr 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh Awaiting requested review from soltysh

@wgliang wgliang Awaiting requested review from wgliang

Assignees

@ahg-g ahg-g

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

Increase the default weight of pod topology spread
6 participants
@alculquicondor @k8s-ci-robot @ahg-g @Huang-Wei @fejta-bot @spiffxp