Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove --feature-gates=DynamicAuditing #91502

Merged
merged 2 commits into from
May 29, 2020
Merged

remove --feature-gates=DynamicAuditing #91502

merged 2 commits into from
May 29, 2020

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented May 27, 2020 •
edited by liggitt
Loading

sig-auth has decided to remove dynamic audit after 1.5 years or so in alpha. See mailing list thread for more details here: https://groups.google.com/forum/#!topic/kubernetes-sig-auth/aV_nXpa5uWU

/kind cleanup
/priority important-soon
@kubernetes/sig-auth-api-reviews

The alpha `DynamicAuditing` feature gate and `auditregistration.k8s.io/v1alpha1` API have been removed and are no longer supported.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/apiserver area/test approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 27, 2020
@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label May 27, 2020
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label May 27, 2020
@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2020
@deads2k deads2k force-pushed the dyn-audit-removal-00 branch 2 times, most recently from a82c89b to defd6c7 Compare May 27, 2020 19:39
liggitt
liggitt reviewed May 27, 2020
View reviewed changes
Copy link
Member

@liggitt liggitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mechanical changes lgtm, a few straggling generated files, looks like

staging/src/k8s.io/client-go/listers/auditregistration/v1alpha1/BUILD Outdated Show resolved Hide resolved
staging/src/k8s.io/client-go/deprecated/scheme/BUILD Outdated Show resolved Hide resolved
staging/src/k8s.io/client-go/deprecated/fake/BUILD Outdated Show resolved Hide resolved
@deads2k
Copy link
Contributor Author

deads2k commented May 28, 2020

/retest

@liggitt
Copy link
Member

liggitt commented May 28, 2020

/lgtm
/approve
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 28, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2020
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

6 similar comments
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit d1586ea into kubernetes:master May 29, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone May 29, 2020
@github-actions github-actions bot mentioned this pull request Jun 2, 2020
Open
@liggitt liggitt mentioned this pull request Jun 8, 2020
Merged
@tengqm tengqm mentioned this pull request Jun 13, 2020
Closed
2 tasks
@riaankleinhans riaankleinhans mentioned this pull request Jul 9, 2020
Closed
tengqm added a commit to tengqm/website that referenced this pull request Jul 16, 2020
@tengqm
Drop DynamicAuditing
c52731f 
The dynamic auditing feature is dropped in 1.19.

Ref1: https://groups.google.com/forum/#!topic/kubernetes-sig-auth/aV_nXpa5uWU
Ref2: kubernetes/kubernetes#91502
@tengqm tengqm mentioned this pull request Jul 16, 2020
Merged
@abursavich abursavich mentioned this pull request Jul 17, 2020
Closed
@PhilipSchmid PhilipSchmid mentioned this pull request Oct 6, 2020
Closed
@hakman hakman mentioned this pull request Nov 13, 2020
Merged
@sftim
Copy link
Contributor

sftim commented Dec 11, 2020 •
edited
Loading

Hmm; the release note from this does not show up in https://relnotes.k8s.io/?areas=audit.

@sirdarckcat sirdarckcat mentioned this pull request Jan 10, 2022
Merged
@tallclair tallclair mentioned this pull request Mar 28, 2022
Merged
@alexzielenski alexzielenski mentioned this pull request Sep 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@CaoShuFeng CaoShuFeng Awaiting requested review from CaoShuFeng

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
5 participants
@deads2k @fejta-bot @liggitt @k8s-ci-robot @sftim