-
Notifications
You must be signed in to change notification settings - Fork 39.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove --feature-gates=DynamicAuditing #91502
Conversation
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
a82c89b
to
defd6c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mechanical changes lgtm, a few straggling generated files, looks like
staging/src/k8s.io/client-go/listers/auditregistration/v1alpha1/BUILD
Outdated
Show resolved
Hide resolved
defd6c7
to
81d1af3
Compare
81d1af3
to
e857adb
Compare
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Review the full test history for this PR. Silence the bot with an |
/retest Review the full test history for this PR. Silence the bot with an |
6 similar comments
/retest Review the full test history for this PR. Silence the bot with an |
/retest Review the full test history for this PR. Silence the bot with an |
/retest Review the full test history for this PR. Silence the bot with an |
/retest Review the full test history for this PR. Silence the bot with an |
/retest Review the full test history for this PR. Silence the bot with an |
/retest Review the full test history for this PR. Silence the bot with an |
The dynamic auditing feature is dropped in 1.19. Ref1: https://groups.google.com/forum/#!topic/kubernetes-sig-auth/aV_nXpa5uWU Ref2: kubernetes/kubernetes#91502
Hmm; the release note from this does not show up in https://relnotes.k8s.io/?areas=audit. |
sig-auth has decided to remove dynamic audit after 1.5 years or so in alpha. See mailing list thread for more details here: https://groups.google.com/forum/#!topic/kubernetes-sig-auth/aV_nXpa5uWU
/kind cleanup
/priority important-soon
@kubernetes/sig-auth-api-reviews