Remove the last provider-specific handling in kubectl.sh, ginkgo-e2e.sh #9227
Conversation
j3ffml
added
the
priority/backlog
|
cc @cjcullen |
|
EXPERIMENTAL JENKINS PR BUILDER: e2e build succeeded. |
|
Cool, thanks. |
| @@ -60,13 +60,6 @@ if [[ -z "${AUTH_CONFIG:-}" ]]; then | |||
| auth_config=( | |||
| "--kubeconfig=${KUBECONFIG:-$DEFAULT_KUBECONFIG}" | |||
| ) | |||
| if [[ "${KUBERNETES_PROVIDER}" == "gke" ]]; then | |||
| # gcloud doesn't override the current-context, so we explicitly set it | |||
| detect-project &> /dev/null | |||
There was a problem hiding this comment.
Do we still want to detect-project here? Are there tests that depend on $ZONE or $PROJECT being set? cc @mbforbes
There was a problem hiding this comment.
Not needed. Tests that depend on zone/project should be calling detect-project themselves.
|
lgtm |
cjcullen
added
the
lgtm
|
@jlowdermilk - Could you rebase this again? Site says PR can't be automatically merged... Thanks. |
|
Rebased. |
|
GCE e2e build/test failed for commit 5fed84414340d17ca13cbe7579f5abd9c9d9dc9d. |
|
@k8s-bot ok to test |
|
GCE e2e build/test passed for commit 5fed84414340d17ca13cbe7579f5abd9c9d9dc9d. |
|
@k8s-bot ok to test Retrying tests. Hopefully test timeout fixes will let this go green. |
|
GCE e2e build/test failed for commit 8233455aba2d6051664d3e7e9bfec454a522fd91. |
|
GCE e2e build/test passed for commit 47901b7. |
Remove the last provider-specific handling in kubectl.sh, ginkgo-e2e.sh
|
some errors here #9237 @jlowdermilk |
|
The 'kubectl get nodes' command doesn't seem to be working in the ubuntu.md file as instructed. |
Last actual use for kubectl.sh. It can now be turned into an initialization script (#8817), just have to go through and correct all the uses.