Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix panic in kubectl --validate when no apiVersion is passed #9597

Merged
merged 1 commit into from Jun 15, 2015
Merged

fix panic in kubectl --validate when no apiVersion is passed #9597

merged 1 commit into from Jun 15, 2015

Conversation

mikedanese
Copy link
Member

actually return validation errors instead of just creating them. whoops.

Fixes: #9224

@satnam6502 satnam6502 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 10, 2015
@mikedanese
Copy link
Member Author

@k8s-bot ok to test

@dchen1107
Copy link
Member

Kubernetes Bot ok to test

@fabioy
Copy link
Contributor

fabioy commented Jun 15, 2015

@k8s-bot ok to test

@fabioy
Copy link
Contributor

fabioy commented Jun 15, 2015

Reissuing test request. Will merge if ok. Thanks.

@k8s-bot
Copy link

k8s-bot commented Jun 15, 2015

GCE e2e build/test failed for commit 2bbb78d.

@mikedanese
Copy link
Member Author 

Summarizing 1 Failure:

[Fail] Service endpoints latency [It] should not be very high 
/go/src/github.com/GoogleCloudPlatform/kubernetes/_output/dockerized/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/service_latency.go:97

Ran 47 of 85 Specs in 292.649 seconds
FAIL! -- 46 Passed | 1 Failed | 2 Pending | 36 Skipped

Looks like the most recent e2e runs have failed with this same test failure. #9759 #9227

@mikedanese
Copy link
Member Author

@k8s-bot ok to test. Seems like a flake.

@mikedanese mikedanese closed this Jun 15, 2015
@mikedanese mikedanese reopened this Jun 15, 2015
@k8s-bot
Copy link

k8s-bot commented Jun 15, 2015

GCE e2e build/test passed for commit 2bbb78d.

fabioy added a commit that referenced this pull request Jun 15, 2015
@fabioy
Merge pull request #9597 from mikedanese/fix-swagger-validate-panic
4e6bd63 
fix panic in kubectl --validate when no apiVersion is passed
@fabioy fabioy merged commit 4e6bd63 into kubernetes:master Jun 15, 2015
@mikedanese mikedanese deleted the fix-swagger-validate-panic branch June 15, 2015 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@satnam6502 satnam6502

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mikedanese @dchen1107 @fabioy @k8s-bot @googlebot @satnam6502