Show resource limits with describe

[jsdir]

Closes #9258

[k8s-bot]

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

[erictune]

ok to test

[k8s-bot]

EXPERIMENTAL JENKINS PR BUILDER: e2e build succeeded.

[ghost]

@bgrant0607 @dchen1107 do either of you have bandwidth to review? I'm a bit snowed under right now.

[derekwaynecarr]

I can review since I requested it

[bgrant0607]

Thanks, @derekwaynecarr

We're removing interpretContainerStatus from kubectl get pods in PR #9032. This looks at status.lastState, among other things. We should add equivalent info to describe. Please at least factor out the big switch on state, so that we could also use it to display lastState.

[derekwaynecarr]

@jsdir - The change looked good when I tried it.

Name:               nginx-7wbly
Image(s):           nginx
Node:               10.245.1.3/10.245.1.3
Labels:             run=nginx
Status:             Running
Replication Controllers:    nginx (1/1 replicas created)
Containers:
  nginx:
    Image:  nginx
    Limits:
      cpu:      250m
      memory:       6Mi
    State:      Running
      Started:      Fri, 05 Jun 2015 16:12:38 -0400
    Ready:      True
    Restart Count:  0
Conditions:

@bgrant0607 - We can hold on this PR until #9032 lands.

[k8s-bot]

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

[derekwaynecarr]

@bgrant0607 - this PR still has the big switch on state, but is an improvement on what existed previously for the end-user. are you fine taking as is and factoring out state in a follow-on?

[bgrant0607]

Yes, I'm fine with refactoring in a separate PR

[bgrant0607]

ok to test

[bgrant0607]

Re-running Shippable.

Otherwise, LGTM.

cc @davidopp for another LGTM

[k8s-bot]

GCE e2e build/test passed for commit cea5aaa.

• Build Log
• Test Artifacts
• Internal Jenkins Results

[davidopp]

LGTM

[mbforbes]

Shippable still hasn't started. Fingers crossed for soon...