Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.17] Update Golang to v1.14.6 #93241

Closed
wants to merge 2 commits into from
Closed

[1.17] Update Golang to v1.14.6 #93241

wants to merge 2 commits into from

Conversation

justaugustus
Copy link
Member

@justaugustus justaugustus commented Jul 20, 2020 •
edited

What type of PR is this?

/kind cleanup
/area dependency release-eng
/sig testing release

What this PR does / why we need it:

Update Golang to v1.14.6.

Tracking issue: kubernetes/release#1410

Which issue(s) this PR fixes:

Special notes for your reviewer:

Includes the go1.13.14 updates from #93233, which will be rebased out once that merges.
Done.

Does this PR introduce a user-facing change?:

- Update Golang to v1.14.6

@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Jul 20, 2020
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 20, 2020
@k8s-ci-robot
Copy link
Contributor

@justaugustus: This cherry pick PR is for a release branch and has not yet been approved by Release Managers.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved (/lgtm + /approve) by the relevant OWNERS.

AFTER it has been approved by code owners, please ping the kubernetes/release-managers team in a comment to request a cherry pick review.

(For details on the patch release process and schedule, see the Patch Releases page.)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/dependency Issues or PRs related to dependency changes area/release-eng Issues or PRs related to the Release Engineering subproject sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/release Categorizes an issue or PR as relevant to SIG Release. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 20, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: justaugustus
To complete the pull request process, please assign liggitt
You can assign the PR to them by writing /assign @liggitt in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from brendandburns, jpbetz and a team July 20, 2020 04:14
@k8s-ci-robot k8s-ci-robot added area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Jul 20, 2020
@justaugustus
Copy link
Member Author

/hold for go1.13.14 merge

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 20, 2020
@justaugustus
Copy link
Member Author

/test pull-kubernetes-integration

@mkumatag mkumatag mentioned this pull request Jul 20, 2020
Closed
18 tasks
@justaugustus
Copy link
Member Author

pull-kubernetes-e2e-gce-device-plugin-gpu is a known flake.
/skip

@justaugustus
Copy link
Member Author

/test pull-kubernetes-integration

@justaugustus
Copy link
Member Author

/test pull-kubernetes-e2e-gce-100-performance

@justaugustus
Copy link
Member Author

/test pull-kubernetes-kubemark-e2e-gce-big

@justaugustus
Update Golang to v1.14.6
15185ad 
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@justaugustus
Update go.etcd.io/bbolt to v1.3.5
f6a6481 
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 20, 2020
@justaugustus
Copy link
Member Author

/hold cancel
(as the previous Golang update has merged and been rebased out of this)

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 20, 2020
@k8s-ci-robot
Copy link
Contributor

@justaugustus: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-device-plugin-gpu f6a6481 link /test pull-kubernetes-e2e-gce-device-plugin-gpu

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@justaugustus
Copy link
Member Author

pull-kubernetes-e2e-gce-device-plugin-gpu is a known flake.
/skip

@justaugustus
Copy link
Member Author

Following the convo in today's Release Team meeting and on Slack, we're going to opt to wait until go1.15 lands and then work on bringing that into previous release branches.

/close

@k8s-ci-robot
Copy link
Contributor

@justaugustus: Closed this PR.

In response to this:

Following the convo in today's Release Team meeting and on Slack, we're going to opt to wait until go1.15 lands and then work on bringing that into previous release branches.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendandburns brendandburns Awaiting requested review from brendandburns

@jpbetz jpbetz Awaiting requested review from jpbetz

Assignees
No one assigned
Labels
area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes area/kubectl area/release-eng Issues or PRs related to the Release Engineering subproject area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@justaugustus @k8s-ci-robot