Implement TopologyInfo and cpu_ids in podresources interface

[AlexeyPerevalov]

/kind api-change

This PR introduces additional information numaid and cpu_ids list (in cpuset list format ).
It implements KEP 1884
It's necessary for topology aware scheduling, this information will be used in topology exposing daemon.

To test it you need to enable KubeletPodResources feature gate in the command line option or in the KubeletConfiguration (by default it's in the /var/lib/kubelet/config.yaml file)

Also you can use following sample to track down pod resources

package main

import (
        "context"
        "fmt"
        "time"

        podresources "k8s.io/kubernetes/pkg/kubelet/apis/podresources"
        podresourcesapi "k8s.io/kubernetes/pkg/kubelet/apis/podresources/v1alpha1"
)

var timeout = 2 * time.Minute

func main() {
        socket := "unix:///var/lib/kubelet/pod-resources/kubelet.sock"
        client, _, err := podresources.GetClient(socket, timeout, 1000)
        if err != nil {
                fmt.Println("Can't create client:", err)
                return
        }
        req := podresourcesapi.ListPodResourcesRequest{}
        resp, err := client.List(context.TODO(), &req)
        if err != nil {
                fmt.Println("Can't receive response:", err)
                return
        }
        for idx := range resp.PodResources {
                podresource := resp.PodResources[idx]
                fmt.Printf("podresource: %v", podresource)
        }
}

Issue: kubernetes/enhancements#2043

[swatisehgal]

We should name this more appropriately, maybe UpdateAllocatedCPUs(). Also, where is this method implemented? I assumed that it would be implemented in cpu_manager.go but didn't find its implementation

[AlexeyPerevalov]

Thanks, nice catch, I forget to remove it from here. In DeviceManager this interface is necessary to actualize podDevices state (GetDevice of DeviceManager return devices from podDevices), for CPUManager, where we return cpu directly - UpdateAllocatedDevices interface is not necessary as well as something like podDevices abstraction, since CPUManager uses CheckpointState for such purpose.

[swatisehgal]

That sounds reasonable!

[swatisehgal]

This line should be corrected to : for _, cpu := range cpus.ToSliceNoSort() The current implementation results in the index values being stored in the result slice (e.g. []int32{0,1,2,3,4....} )

[AlexeyPerevalov]

exactly

[AlexeyPerevalov]

/release-note-none

[AlexeyPerevalov]

/retest

[dims]

/milestone v1.20

[AlexeyPerevalov]

/retest

[spiffxp]

possible github issue, please link if you run into this on other PR's kubernetes/test-infra#19910

[AlexeyPerevalov]

possible github issue, please link if you run into this on other PR's kubernetes/test-infra#19910

Yes, it's
I and prow robot can't
git fetch https://github.com/kubernetes/kubernetes.git pull/93243/head
as result no commits after fetch.

[k8s-ci-robot]

@AlexeyPerevalov: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-kubernetes-e2e-gce-device-plugin-gpu	6e4cc919b5e6ed4bf3e4c1bcfe5d7d22eda31f8a	link	/test pull-kubernetes-e2e-gce-device-plugin-gpu

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[RenaudWasTaken]

/lgtm

[derekwaynecarr]

can you add a node_e2e test that invokes this in a follow-on?

/lgtm
/approve

[derekwaynecarr]

just noting this appears resolved below

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexeyPerevalov, derekwaynecarr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/kubelet/OWNERS [derekwaynecarr]
• staging/src/k8s.io/kubelet/OWNERS [derekwaynecarr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ffromani]

can you add a node_e2e test that invokes this in a follow-on?

/lgtm
/approve

@derekwaynecarr I'm adding e2e tests for podresources in my PR which depends on this one (see 2bda2a7 and
cba703b) We already have basic coverage. If works for you I'll prepare a followup PR to make sure this case is covered explicitely (e.g. checking the NUMA ids)