Fix instance not found issues when an Azure Node is recreated in a short time #93316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This was referenced Jul 22, 2020
|
/sig cloud-provider |
feiskyer
removed
the
needs-sig
|
this one looks more intuitive than #93288 |
k8s-ci-robot
added
the
lgtm
|
/retest |
|
/retest |
|
Add to v1.19 milestone since this is a critical bug fix. |
|
/retest |
|
/retest
…On Wed, Jul 22, 2020 at 1:20 PM Kubernetes Prow Robot < ***@***.***> wrote:
@feiskyer <https://github.com/feiskyer>: The following test *failed*, say
/retest to rerun all failed tests:
Test name Commit Details Rerun command
pull-kubernetes-integration 3588856
<3588856>
link
<https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/93316/pull-kubernetes-integration/1285829311546265605> /test
pull-kubernetes-integration
Full PR test history
<https://prow.k8s.io/pr-history?org=kubernetes&repo=kubernetes&pr=93316>. Your
PR dashboard
<https://prow.k8s.io/pr?query=is%3Apr%20state%3Aopen%20author%3feiskyer>.
Please help us cut down on flakes by linking to
<https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests>
an open issue
<https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open> when
you hit one in your PR.
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#93316 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD24BUANW62VDKEJEZ6Q26DR42K37ANCNFSM4PEIDIDQ>
.
|
|
/retest |
1 similar comment
|
/retest |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/test pull-kubernetes-integration |
This was referenced Jul 27, 2020
k8s-ci-robot
added a commit
that referenced
this pull request
Aug 2, 2020
…-upstream-release-1.16 Automated cherry pick of #93316: Fix instance not found issues when an Azure Node is recreated
k8s-ci-robot
added a commit
that referenced
this pull request
Aug 2, 2020
…-upstream-release-1.17 Automated cherry pick of #93316: Fix instance not found issues when an Azure Node is recreated
k8s-ci-robot
added a commit
that referenced
this pull request
Aug 2, 2020
…-upstream-release-1.18 Automated cherry pick of #93316: Fix instance not found issues when an Azure Node is recreated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/priority critical-urgent
/area provider/azure
/sig cloud-provider
What this PR does / why we need it:
When a node is deleted and then recreated in short time, the "instance not found" error would be reported from Azure cloud provider and hence the node object is deleted by kube-controller-manager.
It is because the deleted VMSS VM would be cached for 15 minutes (this is used to avoid throttling issues when a large number of nodes are deleted) and the cache TTL is not configurable.
This PR fixes the issue by
Which issue(s) this PR fixes:
Fixes #93287
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: