-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Create AppsV1Deployment resource lifecycle test - +6 endpoint coverage #93458
Merged
k8s-ci-robot
merged 6 commits into
kubernetes:master
from
ii:create-deployment-resource-lifecycle-test
Nov 4, 2020
Merged
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
875dddf
Create Deployment resource lifecycle test
BobyMCbobs 29664dd
Update ready condition
BobyMCbobs d4540f2
Update readiness checks
BobyMCbobs 0a6dc83
Fix label reference in deployment checks
BobyMCbobs 8411ada
Adjust default replica count to 2 replicas
BobyMCbobs 2c4117d
Adjusted e2e test watch timeouts, logging and pod management
heyste File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we separate this into multiple tests?
Current test is one of big tests by comparing the other tests in this test package and that would make it difficult to investigate issues if they happen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
every individual test has setup/tear down cost, and our e2e jobs already trend long. A single coherent test that walks an object through its paces seems better to me.