Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test cluster check when starting csi proxy #93789

Merged
merged 1 commit into from
Aug 15, 2020
Merged

Add test cluster check when starting csi proxy #93789

merged 1 commit into from
Aug 15, 2020

Conversation

jingxu97
Copy link
Contributor

@jingxu97 jingxu97 commented Aug 7, 2020 •
edited
Loading

remove the check for test cluster when downloading csi proxy

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 7, 2020
@k8s-ci-robot k8s-ci-robot added sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 7, 2020
@jingxu97
Copy link
Contributor Author

jingxu97 commented Aug 7, 2020

/test pull-kubernetes-e2e-kind

@jingxu97
Copy link
Contributor Author

jingxu97 commented Aug 7, 2020

/retest

yliaog
yliaog reviewed Aug 7, 2020
View reviewed changes
cluster/gce/windows/k8s-node-setup.psm1 Outdated
if (ShouldWrite-File ${env:K8S_DIR}\diskutil.exe) {
# The source code of this executable file is https://github.com/kubernetes-sigs/sig-windows-tools/blob/master/cmd/diskutil/diskutil.c
MustDownload-File -OutFile ${env:K8S_DIR}\diskutil.exe `
-URLs "https://ddebroywin1.s3-us-west-2.amazonaws.com/diskutil.exe"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's kind of ok to download from the above URL if the cluster is for test, it is not ok if it is not for test.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we recently added an API in csi-proxy which will remove the need of this diskutil. I will update driver and remove this part after testing.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 7, 2020
@jingxu97 jingxu97 changed the title Remove test cluster check from csi proxy downloading Add test cluster check when starting csi proxy Aug 7, 2020
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 7, 2020
@jingxu97
Add test cluster check when starting csi proxy
116465b 
Add the check for test cluster when starting csi proxy
@jingxu97
Copy link
Contributor Author

jingxu97 commented Aug 7, 2020

@yliaog @pjh I updated the PR. PTAL

@pjh
Copy link
Contributor

pjh commented Aug 7, 2020

Thanks Jing. So this is now just adding a check that we missed the first time around?

Was there anything else you wanted this PR to do? If we can remove the dependency on diskutil.exe like you said then that would be good, but if we can't do it now then we can just submit this.

@jingxu97
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 11, 2020
@jingxu97
Copy link
Contributor Author

jingxu97 commented Aug 11, 2020 •
edited
Loading

Thanks Jing. So this is now just adding a check that we missed the first time around?

Was there anything else you wanted this PR to do? If we can remove the dependency on diskutil.exe like you said then that would be good, but if we can't do it now then we can just submit this.

Now csi-proxy can handle getDiskName already. But I am waiting for a new release cut so that our build and release pipeline can get the latest version. It should be done this week. We can merge this one first, I think

@jingxu97
Copy link
Contributor Author

@pjh @yliaog PTAL. Thanks!

@yliaog
Copy link
Contributor

yliaog commented Aug 13, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 13, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jingxu97, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2020
@pjh
Copy link
Contributor

pjh commented Aug 13, 2020

/lgtm

Thanks!

@jingxu97 jingxu97 added the kind/bug Categorizes issue or PR as related to a bug. label Aug 13, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Aug 13, 2020
@jingxu97 jingxu97 added this to the v1.19 milestone Aug 15, 2020
@k8s-ci-robot k8s-ci-robot merged commit 529c134 into kubernetes:master Aug 15, 2020
@pjh pjh mentioned this pull request Aug 26, 2020
Closed
@jingxu97 jingxu97 mentioned this pull request Aug 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yliaog yliaog yliaog left review comments

@mtaufen mtaufen Awaiting requested review from mtaufen

@yujuhong yujuhong Awaiting requested review from yujuhong

Assignees

@pjh pjh

@yliaog yliaog

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
4 participants
@jingxu97 @pjh @yliaog @k8s-ci-robot